[GRASS-dev] [GRASS GIS] #2059: WorldView2 relative spectral response data for i.atcorr

#2059: WorldView2 relative spectral response data for i.atcorr
-------------------------------------------------------------+--------------
Reporter: nikosa | Owner: grass-dev@…
     Type: enhancement | Status: new
Priority: normal | Milestone: 7.0.0
Component: Imagery | Version: unspecified
Keywords: i.atcorr, worldview2, sensors, csv, band filter | Platform: Unspecified
      Cpu: Unspecified |
-------------------------------------------------------------+--------------
Attached .csv file, hopefully correctly formatted. The source for the data
was: [http://www.orfeo-
toolbox.org/doxygen/otbWorldView2ImageMetadataInterface_8cxx_source.html],
line 918 and beyond.

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/2059&gt;
GRASS GIS <http://grass.osgeo.org>

#2059: WorldView2 relative spectral response data for i.atcorr
----------------------------------+-----------------------------------------
Reporter: nikosa | Owner: grass-dev@…
     Type: enhancement | Status: new
Priority: normal | Milestone: 7.0.0
Component: Imagery | Version: svn-trunk
Keywords: i.atcorr, worldview2 | Platform: Unspecified
      Cpu: Unspecified |
----------------------------------+-----------------------------------------
Changes (by neteler):

  * keywords: i.atcorr, worldview2, sensors, csv, band filter => i.atcorr,
               worldview2
  * version: unspecified => svn-trunk

Comment:

Would you mind to provide the spectral data as a patch for i.atcorr?
For instructions, see
http://svn.osgeo.org/grass/grass/trunk/imagery/i.atcorr/README

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/2059#comment:1&gt;
GRASS GIS <http://grass.osgeo.org>

#2059: WorldView2 relative spectral response data for i.atcorr
----------------------------------+-----------------------------------------
Reporter: nikosa | Owner: grass-dev@…
     Type: enhancement | Status: new
Priority: normal | Milestone: 7.0.0
Component: Imagery | Version: svn-trunk
Keywords: i.atcorr, worldview2 | Platform: Unspecified
      Cpu: Unspecified |
----------------------------------+-----------------------------------------

Comment(by nikosa):

Replying to [comment:1 neteler]:
> Would you mind to provide the spectral data as a patch for i.atcorr?
> For instructions, see
> http://svn.osgeo.org/grass/grass/trunk/imagery/i.atcorr/README

Yes Markus, that's what it is already. Just need a confirmation from
someone.

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/2059#comment:2&gt;
GRASS GIS <http://grass.osgeo.org>

#2059: WorldView2 relative spectral response data for i.atcorr
----------------------------------+-----------------------------------------
Reporter: nikosa | Owner: grass-dev@…
     Type: enhancement | Status: new
Priority: normal | Milestone: 7.0.0
Component: Imagery | Version: svn-trunk
Keywords: i.atcorr, worldview2 | Platform: Unspecified
      Cpu: Unspecified |
----------------------------------+-----------------------------------------

Comment(by nikosa):

File re-attached. During some "tr" operation in shell, too many commas got
in the header line (in the firstly attached file).

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/2059#comment:3&gt;
GRASS GIS <http://grass.osgeo.org>

#2059: WorldView2 relative spectral response data for i.atcorr
----------------------------------+-----------------------------------------
Reporter: nikosa | Owner: grass-dev@…
     Type: enhancement | Status: new
Priority: normal | Milestone: 7.0.0
Component: Imagery | Version: svn-trunk
Keywords: i.atcorr, worldview2 | Platform: Unspecified
      Cpu: Unspecified |
----------------------------------+-----------------------------------------

Comment(by nikosa):

Replying to [comment:2 nikosa]:
> Replying to [comment:1 neteler]:
> > Would you mind to provide the spectral data as a patch for i.atcorr?
> > For instructions, see
> > http://svn.osgeo.org/grass/grass/trunk/imagery/i.atcorr/README
>
> Yes Markus, that's what it is already. Just need a confirmation from
someone.

If the .csv is fine, I can also try to alter the other files (Iwave.cpp,
Iwave.h, GeomCond.cpp and GeomCond.h). Not now though...

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/2059#comment:4&gt;
GRASS GIS <http://grass.osgeo.org>

#2059: WorldView2 relative spectral response data for i.atcorr
----------------------------------+-----------------------------------------
Reporter: nikosa | Owner: grass-dev@…
     Type: enhancement | Status: new
Priority: normal | Milestone: 7.0.0
Component: Imagery | Version: svn-trunk
Keywords: i.atcorr, worldview2 | Platform: Unspecified
      Cpu: Unspecified |
----------------------------------+-----------------------------------------

Comment(by nikosa):

Diff file attached.

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/2059#comment:5&gt;
GRASS GIS <http://grass.osgeo.org>

#2059: WorldView2 relative spectral response data for i.atcorr
----------------------------------+-----------------------------------------
Reporter: nikosa | Owner: grass-dev@…
     Type: enhancement | Status: new
Priority: normal | Milestone: 7.0.0
Component: Imagery | Version: svn-trunk
Keywords: i.atcorr, worldview2 | Platform: Unspecified
      Cpu: Unspecified |
----------------------------------+-----------------------------------------

Comment(by nikosa):

It does not work...

{{{
GeomCond.cpp: In member function ‘void GeomCond::print()’:
GeomCond.cpp:436:2: error: too many initializers for ‘const string [16]
{aka const std::basic_string<char> [16]}’
make: *** [OBJ.x86_64-unknown-linux-gnu/GeomCond.o] Error 1
}}}

Any help?

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/2059#comment:6&gt;
GRASS GIS <http://grass.osgeo.org>

#2059: WorldView2 relative spectral response data for i.atcorr
----------------------------------+-----------------------------------------
Reporter: nikosa | Owner: grass-dev@…
     Type: enhancement | Status: new
Priority: normal | Milestone: 7.0.0
Component: Imagery | Version: svn-trunk
Keywords: i.atcorr, worldview2 | Platform: Unspecified
      Cpu: Unspecified |
----------------------------------+-----------------------------------------

Comment(by nikosa):

Almost there... I think. I forgot to edit one table in the html file and,
after doing so, it does not compile anymore although it did withouth the
changes in the html file.

{{{
/osgeo/src/grass7_trunk/dist.x86_64-unknown-linux-
gnu/docs/html/i.atcorr.html:240:0: Error (KeyError(None,)): <tr>

make: *** [/osgeo/src/grass7_trunk/dist.x86_64-unknown-linux-
gnu/docs/man/man1/i.atcorr.1] Error 1
rm i.atcorr.tmp.html
}}}

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/2059#comment:7&gt;
GRASS GIS <http://grass.osgeo.org>

#2059: WorldView2 relative spectral response data for i.atcorr
----------------------------------+-----------------------------------------
Reporter: nikosa | Owner: grass-dev@…
     Type: enhancement | Status: new
Priority: normal | Milestone: 7.0.0
Component: Imagery | Version: svn-trunk
Keywords: i.atcorr, worldview2 | Platform: Unspecified
      Cpu: Unspecified |
----------------------------------+-----------------------------------------

Comment(by nikosa):

Typically inexperienced and in a hurry. I forgot to remove something...
It compiles here now :slight_smile:

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/2059#comment:8&gt;
GRASS GIS <http://grass.osgeo.org>

#2059: WorldView2 relative spectral response data for i.atcorr
----------------------------------+-----------------------------------------
Reporter: nikosa | Owner: grass-dev@…
     Type: enhancement | Status: new
Priority: normal | Milestone: 7.0.0
Component: Imagery | Version: svn-trunk
Keywords: i.atcorr, worldview2 | Platform: Unspecified
      Cpu: Unspecified |
----------------------------------+-----------------------------------------

Comment(by nikosa):

Apologies for abusing the platform -- I will try to be more patient before
posting. I don't (didn't) know what the actual implications are when
posting a comment here. If I did any harm, please, let me know if there is
a way to correct it.

Also, how can I post a new comment and at the same time attach a file?
Possible?

----

It seems that I picked the wrong "number" that concern (only) the
description of the bandwidths for WV-2 (from
[http://www.landinfo.com/WorldView2.htm\]). Updated now from the official
source (latest attached file).

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/2059#comment:9&gt;
GRASS GIS <http://grass.osgeo.org>

#2059: WorldView2 relative spectral response data for i.atcorr
----------------------------------+-----------------------------------------
Reporter: nikosa | Owner: grass-dev@…
     Type: enhancement | Status: new
Priority: normal | Milestone: 7.0.0
Component: Imagery | Version: svn-trunk
Keywords: i.atcorr, worldview2 | Platform: Unspecified
      Cpu: Unspecified |
----------------------------------+-----------------------------------------

Comment(by hamish):

Replying to [comment:9 nikosa]:
> Also, how can I post a new comment and at the same time attach a file?
Possible?

I think that only works when you are creating a new ticket. Otherwise it
has to be done in two steps.

regards,
Hamish

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/2059#comment:10&gt;
GRASS GIS <http://grass.osgeo.org>

#2059: WorldView2 relative spectral response data for i.atcorr
----------------------------------+-----------------------------------------
Reporter: nikosa | Owner: grass-dev@…
     Type: enhancement | Status: new
Priority: normal | Milestone: 7.0.0
Component: Imagery | Version: svn-trunk
Keywords: i.atcorr, worldview2 | Platform: Unspecified
      Cpu: Unspecified |
----------------------------------+-----------------------------------------

Comment(by nikosa):

Anyone that can review and apply the diff? Thank you.

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/2059#comment:11&gt;
GRASS GIS <http://grass.osgeo.org>

#2059: WorldView2 relative spectral response data for i.atcorr
----------------------------------+-----------------------------------------
Reporter: nikosa | Owner: grass-dev@…
     Type: enhancement | Status: new
Priority: normal | Milestone: 7.0.0
Component: Imagery | Version: svn-trunk
Keywords: i.atcorr, worldview2 | Platform: Unspecified
      Cpu: Unspecified |
----------------------------------+-----------------------------------------

Comment(by neteler):

Are there any sample data available to test the patch?

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/2059#comment:12&gt;
GRASS GIS <http://grass.osgeo.org>

#2059: WorldView2 relative spectral response data for i.atcorr
----------------------------------+-----------------------------------------
Reporter: nikosa | Owner: grass-dev@…
     Type: enhancement | Status: new
Priority: normal | Milestone: 7.0.0
Component: Imagery | Version: svn-trunk
Keywords: i.atcorr, worldview2 | Platform: Unspecified
      Cpu: Unspecified |
----------------------------------+-----------------------------------------

Comment(by nikosa):

Back to this,

QuickBird2 samples available from GLCF:
http://glcf.umd.edu/data/quickbird/, e.g. I recently used some from
ftp://ftp.glcf.umd.edu/glcf/QuickBird/02NOV21044347-X2AS_R1C1-000000185940_01_P001
-India-The_Sundarbans

WorldView2 sample image available from Apollo Mapping:
http://apollomapping.com/image_downloads/WV2_8band_Bundle_Sydney_Australia.zip

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/2059#comment:13&gt;
GRASS GIS <http://grass.osgeo.org>

#2059: WorldView2 relative spectral response data for i.atcorr
----------------------------------+-----------------------------------------
Reporter: nikosa | Owner: grass-dev@…
     Type: enhancement | Status: new
Priority: normal | Milestone: 7.0.0
Component: Imagery | Version: svn-trunk
Keywords: i.atcorr, worldview2 | Platform: Unspecified
      Cpu: Unspecified |
----------------------------------+-----------------------------------------

Comment(by nikosa):

Looking at:

grass70/imagery/i.atcorr $ grep -nr wv2 *
iwave.cpp:2463: /* WV2 Pan of wv2_spectral_response */
iwave.cpp:2505: /* WV2 Coastal Blue of wv2_spectral_response */
iwave.cpp:2547: /* WV2 Blue of wv2_spectral_response */
iwave.cpp:2589: /* WV2 Green of wv2_spectral_response */
iwave.cpp:2631: /* WV2 Yellow of wv2_spectral_response */
iwave.cpp:2673: /* WV2 Red of wv2_spectral_response */
iwave.cpp:2715: /* WV2 RedEdge of wv2_spectral_response */
iwave.cpp:2757: /* WV2 NIR1 of wv2_spectral_response */
iwave.cpp:2799: /* WV2 NIR2 of wv2_spectral_response */

it seems that support has been added. Didn't notice when. Is there any
reference? Should this ticket be closed?

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/2059#comment:14&gt;
GRASS GIS <http://grass.osgeo.org>

#2059: WorldView2 relative spectral response data for i.atcorr
----------------------------------+-----------------------------------------
Reporter: nikosa | Owner: grass-dev@…
     Type: enhancement | Status: new
Priority: normal | Milestone: 7.0.0
Component: Imagery | Version: svn-trunk
Keywords: i.atcorr, worldview2 | Platform: Unspecified
      Cpu: Unspecified |
----------------------------------+-----------------------------------------

Comment(by neteler):

Replying to [comment:14 nikosa]:
> it seems that support has been added. Didn't notice when. Is there any
reference? Should this ticket be closed?

It got accidentally submitted in this mixed patch: r60610 (releasebranch7:
r61314).

This ticket can be closed once the WorldView2 support has been tested. Can
you do that?

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/2059#comment:15&gt;
GRASS GIS <http://grass.osgeo.org>

#2059: WorldView2 relative spectral response data for i.atcorr
----------------------------------+-----------------------------------------
Reporter: nikosa | Owner: grass-dev@…
     Type: enhancement | Status: new
Priority: normal | Milestone: 7.0.0
Component: Imagery | Version: svn-trunk
Keywords: i.atcorr, worldview2 | Platform: Unspecified
      Cpu: Unspecified |
----------------------------------+-----------------------------------------

Comment(by nikosa):

The data seem to be wrong. I updated (again), see attached file (next
post). A quick test with a blue WorldView?2 band, though, didn't seem to
work-out well :-(.

ps- can we remove old attached files?

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/2059#comment:16&gt;
GRASS GIS <http://grass.osgeo.org>

#2059: WorldView2 relative spectral response data for i.atcorr
----------------------------------+-----------------------------------------
Reporter: nikosa | Owner: grass-dev@…
     Type: enhancement | Status: new
Priority: normal | Milestone: 7.0.0
Component: Imagery | Version: svn-trunk
Keywords: i.atcorr, worldview2 | Platform: Unspecified
      Cpu: Unspecified |
----------------------------------+-----------------------------------------

Comment(by neteler):

Replying to [comment:16 nikosa]:
> The data seem to be wrong. I updated (again), see attached file (next
post).

Which post?

> A quick test with a blue WorldView?2 band, though, didn't seem to work-
out well :-(.
>
> ps- can we remove old attached files?

No, AFAIK trac does not support this. The trick is to *substitute* patches
(use the same attachment name and click on the "overwrite" checkbox).

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/2059#comment:17&gt;
GRASS GIS <http://grass.osgeo.org>

#2059: WorldView2 relative spectral response data for i.atcorr
----------------------------------+-----------------------------------------
Reporter: nikosa | Owner: grass-dev@…
     Type: enhancement | Status: new
Priority: normal | Milestone: 7.0.0
Component: Imagery | Version: svn-trunk
Keywords: i.atcorr, worldview2 | Platform: Unspecified
      Cpu: Unspecified |
----------------------------------+-----------------------------------------

Comment(by nikosa):

Replying to [comment:17 neteler]:
> Replying to [comment:16 nikosa]:
> > The data seem to be wrong. I updated (again), see attached file (next
post).
>
> Which post?

File attached in the previous msg:
http://trac.osgeo.org/grass/attachment/ticket/2059/worldview2_cpp_template.txt

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/2059#comment:18&gt;
GRASS GIS <http://grass.osgeo.org>

#2059: WorldView2 relative spectral response data for i.atcorr
--------------------------+----------------------------------
  Reporter: nikosa | Owner: grass-dev@…
      Type: enhancement | Status: new
  Priority: normal | Milestone: 7.0.0
Component: Imagery | Version: svn-trunk
Resolution: | Keywords: i.atcorr, worldview2
       CPU: Unspecified | Platform: Unspecified
--------------------------+----------------------------------

Comment (by neteler):

Replying to [ticket:2059 nikosa]:
> Attached .csv file, hopefully correctly formatted. The source for the
data was: [http://www.orfeo-
toolbox.org/doxygen/otbWorldView2ImageMetadataInterface_8cxx_source.html],
line 918 and beyond.

Just for the record: current file position as of OTB 5.0:

http://hg.orfeo-
toolbox.org/OTB/file/6b41126f5257/Modules/Core/Metadata/src/

--> otbWorldView2ImageMetadataInterface.cxx

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/2059#comment:19&gt;
GRASS GIS <http://grass.osgeo.org>