[GRASS-dev] [GRASS GIS] #2440: remove unused elements from g.list/g.remove

#2440: remove unused elements from g.list/g.remove
--------------------------------+-------------------------------------------
Reporter: annakrat | Owner: grass-dev@…
     Type: task | Status: new
Priority: normal | Milestone: 7.0.0
Component: LibGIS | Version: svn-releasebranch70
Keywords: elements, g.remove | Platform: All
      Cpu: Unspecified |
--------------------------------+-------------------------------------------
Half of the elements in g.remove and related modules are not used any
more. Let's remove them from GRASS7.
  * old (GRASS 5.0) vector map(s)
  * ASCII vector map(s)
  * paint icon file(s)
  * paint label file(s)
  * site list file(s)
  * 3D view parameter(s)

Please correct me if we still use some of them. Technically it's easy to
remove them, just remove a couple of lines in lib/manage/element_list
file.

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/2440&gt;
GRASS GIS <http://grass.osgeo.org>

#2440: remove unused elements from g.list/g.remove
--------------------------------+-------------------------------------------
Reporter: annakrat | Owner: grass-dev@…
     Type: task | Status: new
Priority: normal | Milestone: 7.0.0
Component: LibGIS | Version: svn-releasebranch70
Keywords: elements, g.remove | Platform: All
      Cpu: Unspecified |
--------------------------------+-------------------------------------------

Comment(by martinl):

Replying to [ticket:2440 annakrat]:
> Half of the elements in g.remove and related modules are not used any
more. Let's remove them from GRASS7.

agreed.

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/2440#comment:1&gt;
GRASS GIS <http://grass.osgeo.org>

#2440: remove unused elements from g.list/g.remove
--------------------------------+-------------------------------------------
Reporter: annakrat | Owner: grass-dev@…
     Type: task | Status: new
Priority: normal | Milestone: 7.0.0
Component: LibGIS | Version: svn-releasebranch70
Keywords: elements, g.remove | Platform: All
      Cpu: Unspecified |
--------------------------------+-------------------------------------------

Comment(by annakrat):

Hm, we still have v.in.sites and v.in.sites.all so I would suggest to
remove them too, as well as the library (lib/sites). Does anyone know
what's the status of 'paint label file'? There are modules v.label and
d.labels so it seems that we should still support it. For the other
elements I couldn't find any module which would be using them so they can
be removed safely.

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/2440#comment:2&gt;
GRASS GIS <http://grass.osgeo.org>

#2440: remove unused elements from g.list/g.remove
--------------------------------+-------------------------------------------
Reporter: annakrat | Owner: grass-dev@…
     Type: task | Status: new
Priority: normal | Milestone: 7.0.0
Component: LibGIS | Version: svn-releasebranch70
Keywords: elements, g.remove | Platform: All
      Cpu: Unspecified |
--------------------------------+-------------------------------------------

Comment(by neteler):

Replying to [comment:2 annakrat]:
> Hm, we still have v.in.sites and v.in.sites.all so I would suggest to
remove them too, as well as the library (lib/sites).

Yes

> Does anyone know what's the status of 'paint label file'? There are
modules v.label and d.labels so it seems that we should still support it.

(there is also v.label.sa lurking ...)

> For the other elements I couldn't find any module which would be using
them so they can be removed safely.

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/2440#comment:3&gt;
GRASS GIS <http://grass.osgeo.org>

#2440: remove unused elements from g.list/g.remove
--------------------------------+-------------------------------------------
Reporter: annakrat | Owner: grass-dev@…
     Type: task | Status: new
Priority: normal | Milestone: 7.0.0
Component: LibGIS | Version: svn-releasebranch70
Keywords: elements, g.remove | Platform: All
      Cpu: Unspecified |
--------------------------------+-------------------------------------------

Comment(by annakrat):

I removed sites element together with the library in r62179, then I
removed paint icons in r62180 (I have no idea what it is and I haven't
found any related library) and finally I removed 3dview element, but I
kept the library itself, since it still might be useful I think. I would
appreciate if someone else could have a look at the old vector formats, I
have no idea what is the difference between them and which libraries they
use. I think we don't need any of them in GRASS7.

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/2440#comment:4&gt;
GRASS GIS <http://grass.osgeo.org>

#2440: remove unused elements from g.list/g.remove
--------------------------------+-------------------------------------------
Reporter: annakrat | Owner: grass-dev@…
     Type: task | Status: new
Priority: normal | Milestone: 7.0.0
Component: LibGIS | Version: svn-releasebranch70
Keywords: elements, g.remove | Platform: All
      Cpu: Unspecified |
--------------------------------+-------------------------------------------

Comment(by martinl):

After some cleaning done with #2409 the list of elements is now

{{{
                raster: raster map(s)
                raster_3d: 3D raster map(s)
                vector: vector map(s)
                old_vector: old (GRASS 5.0) vector map(s)
                ascii_vector: ASCII vector map(s)
                labels: paint label file(s)
                region: region definition(s)
                group: imagery group(s)
                all: all types
}}}

Is it OK to close this ticket or is there still any remaining issue?

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/2440#comment:5&gt;
GRASS GIS <http://grass.osgeo.org>

#2440: remove unused elements from g.list/g.remove
--------------------------------+-------------------------------------------
Reporter: annakrat | Owner: grass-dev@…
     Type: task | Status: new
Priority: normal | Milestone: 7.0.0
Component: LibGIS | Version: svn-releasebranch70
Keywords: elements, g.remove | Platform: All
      Cpu: Unspecified |
--------------------------------+-------------------------------------------
Changes (by martinl):

* cc: martinl (added)

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/2440#comment:6&gt;
GRASS GIS <http://grass.osgeo.org>

#2440: remove unused elements from g.list/g.remove
--------------------------------+-------------------------------------------
Reporter: annakrat | Owner: grass-dev@…
     Type: task | Status: new
Priority: normal | Milestone: 7.0.0
Component: LibGIS | Version: svn-releasebranch70
Keywords: elements, g.remove | Platform: All
      Cpu: Unspecified |
--------------------------------+-------------------------------------------

Comment(by neteler):

As of r63875 it is

{{{
                raster: raster map(s)
                raster_3d: 3D raster map(s)
                vector: vector map(s)
                ascii_vector: ASCII vector map(s)
                labels: paint label file(s)
                region: region definition(s)
                group: imagery group(s)
                all: all types
}}}

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/2440#comment:7&gt;
GRASS GIS <http://grass.osgeo.org>

#2440: remove unused elements from g.list/g.remove
--------------------------------+-------------------------------------------
Reporter: annakrat | Owner: grass-dev@…
     Type: task | Status: new
Priority: normal | Milestone: 7.0.0
Component: LibGIS | Version: svn-releasebranch70
Keywords: elements, g.remove | Platform: All
      Cpu: Unspecified |
--------------------------------+-------------------------------------------

Comment(by annakrat):

There is still the `ascii_vector`, I have no idea what it is.

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/2440#comment:8&gt;
GRASS GIS <http://grass.osgeo.org>

#2440: remove unused elements from g.list/g.remove
--------------------------------+-------------------------------------------
Reporter: annakrat | Owner: grass-dev@…
     Type: task | Status: new
Priority: blocker | Milestone: 7.0.0
Component: LibGIS | Version: svn-releasebranch70
Keywords: elements, g.remove | Platform: All
      Cpu: Unspecified |
--------------------------------+-------------------------------------------
Changes (by martinl):

  * priority: normal => blocker

Comment:

Replying to [comment:8 annakrat]:
> There is still the `ascii_vector`, I have no idea what it is.

I also don't know. Anyone has an idea? If not I would suggest to remove it
too.

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/2440#comment:9&gt;
GRASS GIS <http://grass.osgeo.org>

#2440: remove unused elements from g.list/g.remove
--------------------------------+-------------------------------------------
Reporter: annakrat | Owner: grass-dev@…
     Type: task | Status: new
Priority: blocker | Milestone: 7.0.0
Component: LibGIS | Version: svn-releasebranch70
Keywords: elements, g.remove | Platform: All
      Cpu: Unspecified |
--------------------------------+-------------------------------------------

Comment(by neteler):

Replying to [comment:9 martinl]:
> Replying to [comment:8 annakrat]:
> > There is still the `ascii_vector`, I have no idea what it is.
>
> I also don't know. Anyone has an idea? If not I would suggest to remove
it too.

http://grass.osgeo.org/grass70/manuals/v.out.ascii.html

"If old version is requested, the output files from v.out.ascii is placed
in the $LOCATION/$MAPSET/dig_ascii/ and $LOCATION/$MAPSET/dig_att
directory."

So, it stems from GRASS GIS 4 and older. Random citation:

GRASS-Intergraph Data Conversion Guide by V Harmon - ‎1992,
http://www.dtic.mil/get-tr-doc/pdf?AD=ADA251458 (p. 14)

Less used nowadays :slight_smile:

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/2440#comment:10&gt;
GRASS GIS <http://grass.osgeo.org>

#2440: remove unused elements from g.list/g.remove
--------------------------------+-------------------------------------------
Reporter: annakrat | Owner: grass-dev@…
     Type: task | Status: new
Priority: blocker | Milestone: 7.0.0
Component: LibGIS | Version: svn-releasebranch70
Keywords: elements, g.remove | Platform: All
      Cpu: Unspecified |
--------------------------------+-------------------------------------------

Comment(by martinl):

> http://grass.osgeo.org/grass70/manuals/v.out.ascii.html
>
> "If old version is requested, the output files from v.out.ascii is
placed in the $LOCATION/$MAPSET/dig_ascii/ and $LOCATION/$MAPSET/dig_att
directory."
>
> So, it stems from GRASS GIS 4 and older. Random citation:
>
> GRASS-Intergraph Data Conversion Guide by V Harmon - ‎1992,
http://www.dtic.mil/get-tr-doc/pdf?AD=ADA251458 (p. 14)
>
> Less used nowadays :slight_smile:

if it's only one usage I would still to vote for removing it from element
list. What do you think?

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/2440#comment:11&gt;
GRASS GIS <http://grass.osgeo.org>

#2440: remove unused elements from g.list/g.remove
--------------------------------+-------------------------------------------
Reporter: annakrat | Owner: grass-dev@…
     Type: task | Status: new
Priority: blocker | Milestone: 7.0.0
Component: LibGIS | Version: svn-releasebranch70
Keywords: elements, g.remove | Platform: All
      Cpu: Unspecified |
--------------------------------+-------------------------------------------

Comment(by martinl):

Replying to [comment:11 martinl]:
> > http://grass.osgeo.org/grass70/manuals/v.out.ascii.html
> >
> > "If old version is requested, the output files from v.out.ascii is
placed in the $LOCATION/$MAPSET/dig_ascii/ and $LOCATION/$MAPSET/dig_att
directory."
> >
> > So, it stems from GRASS GIS 4 and older. Random citation:
> >
> > GRASS-Intergraph Data Conversion Guide by V Harmon - ‎1992,
http://www.dtic.mil/get-tr-doc/pdf?AD=ADA251458 (p. 14)
> >
> > Less used nowadays :slight_smile:
>
> if it's only one usage I would still to vote for removing it from
element list. What do you think?

any option?

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/2440#comment:12&gt;
GRASS GIS <http://grass.osgeo.org>

#2440: remove unused elements from g.list/g.remove
--------------------------------+-------------------------------------------
Reporter: annakrat | Owner: grass-dev@…
     Type: task | Status: new
Priority: blocker | Milestone: 7.0.0
Component: LibGIS | Version: svn-releasebranch70
Keywords: elements, g.remove | Platform: All
      Cpu: Unspecified |
--------------------------------+-------------------------------------------

Comment(by martinl):

Replying to [comment:12 martinl]:

> > if it's only one usage I would still to vote for removing it from
element list. What do you think?
>
> any option?

I removed `ascii_vector` in trunk as r64004. Any objection to backport to
`relbr70`?

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/2440#comment:13&gt;
GRASS GIS <http://grass.osgeo.org>

#2440: remove unused elements from g.list/g.remove
--------------------------------+-------------------------------------------
Reporter: annakrat | Owner: grass-dev@…
     Type: task | Status: new
Priority: blocker | Milestone: 7.0.0
Component: LibGIS | Version: svn-releasebranch70
Keywords: elements, g.remove | Platform: All
      Cpu: Unspecified |
--------------------------------+-------------------------------------------

Comment(by martinl):

Replying to [comment:13 martinl]:
> Replying to [comment:12 martinl]:
>
> > > if it's only one usage I would still to vote for removing it from
element list. What do you think?
> >
> > any option?
>
> I removed `ascii_vector` in trunk as r64004. Any objection to backport
to `relbr70`?

r64004:64005

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/2440#comment:14&gt;
GRASS GIS <http://grass.osgeo.org>

#2440: remove unused elements from g.list/g.remove
--------------------------------+-------------------------------------------
Reporter: annakrat | Owner: grass-dev@…
     Type: task | Status: new
Priority: blocker | Milestone: 7.0.0
Component: LibGIS | Version: svn-releasebranch70
Keywords: elements, g.remove | Platform: All
      Cpu: Unspecified |
--------------------------------+-------------------------------------------

Comment(by martinl):

Replying to [comment:14 martinl]:

> > I removed `ascii_vector` in trunk as r64004. Any objection to backport
to `relbr70`?
>
> r64004:64005

done in r64104

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/2440#comment:15&gt;
GRASS GIS <http://grass.osgeo.org>

#2440: remove unused elements from g.list/g.remove
--------------------------------+-------------------------------------------
Reporter: annakrat | Owner: grass-dev@…
     Type: task | Status: new
Priority: blocker | Milestone: 7.0.0
Component: LibGIS | Version: svn-releasebranch70
Keywords: elements, g.remove | Platform: All
      Cpu: Unspecified |
--------------------------------+-------------------------------------------

Comment(by martinl):

Currently the element list looks like:

{{{
        type Data type(s)
               options: raster,raster_3d,vector,label,region,group,all
                raster: raster map(s)
                raster_3d: 3D raster map(s)
                vector: vector map(s)
                label: paint label file(s)
                region: region definition(s)
                group: imagery group(s)
                all: all types
}}}

Is there any open issue?

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/2440#comment:16&gt;
GRASS GIS <http://grass.osgeo.org>

#2440: remove unused elements from g.list/g.remove
-----------------------+----------------------------------------------------
  Reporter: annakrat | Owner: grass-dev@…
      Type: task | Status: closed
  Priority: blocker | Milestone: 7.0.0
Component: LibGIS | Version: svn-releasebranch70
Resolution: fixed | Keywords: elements, g.remove
  Platform: All | Cpu: Unspecified
-----------------------+----------------------------------------------------
Changes (by annakrat):

  * status: new => closed
  * resolution: => fixed

Comment:

Thanks! I think we can close it. The actual code for handling different
vector formats is still there, but from what I remember when I was looking
at it, it would be quite time consuming to clean it up.

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/2440#comment:17&gt;
GRASS GIS <http://grass.osgeo.org>