[GRASS-dev] [GRASS GIS] #2777: Drop menu file in favor of desktop file

#2777: Drop menu file in favor of desktop file
-------------------------+-------------------------
Reporter: sebastic | Owner: grass-dev@…
     Type: enhancement | Status: new
Priority: normal | Milestone: 7.0.2
Component: Packaging | Version: svn-trunk
Keywords: | CPU: All
Platform: Linux |
-------------------------+-------------------------
The menu files are no longer required for the Debian packages since
[https://lists.debian.org/debian-devel-announce/2015/09/msg00000.html CTTE
#741573 - Debian Menu System] which advised:

> In addition to those changes, the Technical Committee resolves that
> packages providing a .desktop file shall not also provide a menu file
> for the same application.

In the attached patch the menu file and its associated XPM icon are
removed, leaving the desktop file and its associated PNG icons in its
place.

The PNG icons are installed in the hicolor theme following the
[http://standards.freedesktop.org/icon-theme-spec/icon-theme-spec-
latest.html#install_icons Icon Theme Specification]:

> So, you're an application author, and want to install application icons
> so that they work in the KDE and Gnome menus. Minimally you should
install
> a 48x48 icon in the hicolor theme. This means installing a PNG file in
> $prefix/share/icons/hicolor/48x48/apps. Optionally you can install icons
> in different sizes. For example, installing a svg icon in
> $prefix/share/icons/hicolor/scalable/apps means most desktops will have
> one icon that works for all sizes. You might even want to install icons
> with a look that matches other well known themes so your application
will
> fit in with some specific desktop environment.

The SVG icon
([https://grass.osgeo.org/uploads/images/logo/grasslogo_vector.svg
grasslogo_vector.svg]) is also installed to have an icon for all size
besides 48x48 & 64x64.

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/2777&gt;
GRASS GIS <https://grass.osgeo.org>

#2777: Drop menu file in favor of desktop file
--------------------------+-------------------------
  Reporter: sebastic | Owner: grass-dev@…
      Type: enhancement | Status: new
  Priority: normal | Milestone: 7.0.2
Component: Packaging | Version: svn-trunk
Resolution: | Keywords:
       CPU: All | Platform: Linux
--------------------------+-------------------------
Changes (by sebastic):

* Attachment "ctte-741573.patch" added.

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/2777&gt;
GRASS GIS <https://grass.osgeo.org>

#2777: Drop menu file in favor of desktop file
--------------------------+-------------------------
  Reporter: sebastic | Owner: grass-dev@…
      Type: enhancement | Status: new
  Priority: normal | Milestone: 7.0.2
Component: Packaging | Version: svn-trunk
Resolution: | Keywords:
       CPU: All | Platform: Linux
--------------------------+-------------------------

Comment (by sebastic):

To make use of the changes in `ctte-741573.patch​` in the
[https://code.launchpad.net/~grass/grass/grass_trunk_debian grass Debian
packaging on Launchpad], have a look at the packaging changes in the
[https://anonscm.debian.org/cgit/pkg-
grass/grass.git/commit/?id=1c42c5f33f03f5e18d6f3a6eceff42a0ff548932 Use
desktop file in favor of menu file per CTTE #741573.] commit in the Debian
GIS git repository.

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/2777#comment:1&gt;
GRASS GIS <https://grass.osgeo.org>

#2777: Drop menu file in favor of desktop file
---------------------------+-------------------------
  Reporter: sebastic | Owner: grass-dev@…
      Type: enhancement | Status: new
  Priority: normal | Milestone: 7.0.2
Component: Installation | Version: svn-trunk
Resolution: | Keywords:
       CPU: All | Platform: Linux
---------------------------+-------------------------
Changes (by sebastic):

* component: Packaging => Installation

Comment:

This didn't make it into 7.0.2RC2, can we get it into RC3 or 7.0.2 final?

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/2777#comment:2&gt;
GRASS GIS <https://grass.osgeo.org>

#2777: Drop menu file in favor of desktop file
---------------------------+-------------------------
  Reporter: sebastic | Owner: grass-dev@…
      Type: enhancement | Status: new
  Priority: normal | Milestone: 7.0.2
Component: Installation | Version: svn-trunk
Resolution: | Keywords:
       CPU: All | Platform: Linux
---------------------------+-------------------------

Comment (by neteler):

Replying to [comment:2 sebastic]:
> This didn't make it into 7.0.2RC2, can we get it into RC3 or 7.0.2
final?

Is it generic or Debian specific? We also support Fedora, Gentoo, other
(Linux and non) distros.

From the provided patch I am not able to judge that.

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/2777#comment:3&gt;
GRASS GIS <https://grass.osgeo.org>

#2777: Drop menu file in favor of desktop file
---------------------------+-------------------------
  Reporter: sebastic | Owner: grass-dev@…
      Type: enhancement | Status: new
  Priority: normal | Milestone: 7.0.2
Component: Installation | Version: svn-trunk
Resolution: | Keywords:
       CPU: All | Platform: Linux
---------------------------+-------------------------

Comment (by sebastic):

It's generic, it applies to all systems implementing the Freedesktop.org
standards.

Because GRASS now installs the hicolor icons, the distribution packaging
can use that instead of its own.

Only dropping the menu files and its associated xpm icon is Debian
specific. This just makes the Freedesktop.org standards more important.

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/2777#comment:4&gt;
GRASS GIS <https://grass.osgeo.org>

#2777: Drop menu file in favor of desktop file
---------------------------+-------------------------
  Reporter: sebastic | Owner: grass-dev@…
      Type: enhancement | Status: new
  Priority: normal | Milestone: 7.0.2
Component: Installation | Version: svn-trunk
Resolution: | Keywords:
       CPU: All | Platform: Linux
---------------------------+-------------------------
Changes (by sebastic):

* Attachment "desktop.patch" added.

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/2777&gt;
GRASS GIS <https://grass.osgeo.org>

#2777: Drop menu file in favor of desktop file
---------------------------+-------------------------
  Reporter: sebastic | Owner: grass-dev@…
      Type: enhancement | Status: new
  Priority: normal | Milestone: 7.0.2
Component: Installation | Version: svn-trunk
Resolution: | Keywords:
       CPU: All | Platform: Linux
---------------------------+-------------------------

Comment (by sebastic):

Because `ctte-741573.patch​` installs the icons as `grass70.{png,svg}` the
`Icon` field in the desktop file also needs to changed to `grass70` as
done in `desktop.patch`.

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/2777#comment:5&gt;
GRASS GIS <https://grass.osgeo.org>

#2777: Drop menu file in favor of desktop file
---------------------------+-------------------------
  Reporter: sebastic | Owner: grass-dev@…
      Type: enhancement | Status: new
  Priority: normal | Milestone: 7.0.3
Component: Installation | Version: svn-trunk
Resolution: | Keywords:
       CPU: All | Platform: Linux
---------------------------+-------------------------
Changes (by sebastic):

* milestone: 7.0.2 => 7.0.3

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/2777#comment:6&gt;
GRASS GIS <https://grass.osgeo.org>

#2777: Drop menu file in favor of desktop file
---------------------------+-------------------------
  Reporter: sebastic | Owner: grass-dev@…
      Type: enhancement | Status: new
  Priority: normal | Milestone: 7.0.3
Component: Installation | Version: svn-trunk
Resolution: | Keywords:
       CPU: All | Platform: Linux
---------------------------+-------------------------

Comment (by neteler):

desktop.patch​ applied in r66865 (trunk) and r66866 (relbr70).

From ctte-741573.patch​ I understand that the file grass.menu + grass.xpm
shall be removed rather than emptied. Done in r66867. If that's right,
r66867 needs to be backported.

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/2777#comment:7&gt;
GRASS GIS <https://grass.osgeo.org>

#2777: Drop menu file in favor of desktop file
---------------------------+-------------------------
  Reporter: sebastic | Owner: grass-dev@…
      Type: enhancement | Status: new
  Priority: normal | Milestone: 7.0.3
Component: Installation | Version: svn-trunk
Resolution: | Keywords:
       CPU: All | Platform: Linux
---------------------------+-------------------------

Comment (by sebastic):

Yes, the menu file and its associated XPM icon are no longer required and
are removed by the patch.

r66867 is appropriate for r66866 because they both reference the grass70
icon, in trunk the icons need to be installed as grass71.{svg,png} to
match r66865.

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/2777#comment:8&gt;
GRASS GIS <https://grass.osgeo.org>

#2777: Drop menu file in favor of desktop file
---------------------------+-------------------------
  Reporter: sebastic | Owner: grass-dev@…
      Type: enhancement | Status: closed
  Priority: normal | Milestone: 7.0.3
Component: Installation | Version: svn-trunk
Resolution: fixed | Keywords:
       CPU: All | Platform: Linux
---------------------------+-------------------------
Changes (by neteler):

* status: new => closed
* resolution: => fixed

Comment:

Replying to [comment:8 sebastic]:
> r66867 is appropriate for r66866 because they both reference the grass70
icon,

backported in r66875.

> in trunk the icons need to be installed as grass71.{svg,png} to match
r66865.

Ah right. Fixed in r66876.

closing.

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/2777#comment:9&gt;
GRASS GIS <https://grass.osgeo.org>