[GRASS-dev] [GRASS GIS] #3718: wingrass: include also unversioned libraries

GDAL · December 26, 2018, 6:01pm

#3718: wingrass: include also unversioned libraries
-----------------------+-------------------------
Reporter: martinl | Owner: grass-dev@…
Type: task | Status: new
Priority: normal | Milestone: 7.4.4
Component: Packaging | Version: svn-trunk
Keywords: wingrass | CPU: Unspecified
Platform: MSWindows |
-----------------------+-------------------------
Currently WinGRASS builds contain only versioned GRASS libs, eg.
`libgrass_gis.x.y.z.dll`. This makes QGIS GRASS broken in OSGeo4W
framework everytime when a new GRASS point version is released and QGIS
GRASS plugin is still compiled against old point version. WinGRASS could
contain also copy of unversioned libs to avoid such problem (creating
symlinks as done on non-mingw platform cannot work here).

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/3718>
GRASS GIS <https://grass.osgeo.org>

GDAL · December 26, 2018, 6:01pm

#3718: wingrass: include also unversioned libraries
--------------------------+-----------------------
  Reporter: martinl | Owner: martinl
      Type: task | Status: assigned
  Priority: normal | Milestone: 7.4.4
Component: Packaging | Version: svn-trunk
Resolution: | Keywords: wingrass
       CPU: Unspecified | Platform: MSWindows
--------------------------+-----------------------
Changes (by martinl):

* cc: grass-dev@… (added)
* owner: grass-dev@… => martinl
* status: new => assigned

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/3718#comment:1>
GRASS GIS <https://grass.osgeo.org>

GDAL · December 26, 2018, 6:05pm

#3718: wingrass: include also unversioned libraries
--------------------------+-----------------------
  Reporter: martinl | Owner: martinl
      Type: task | Status: assigned
  Priority: normal | Milestone: 7.4.4
Component: Packaging | Version: svn-trunk
Resolution: | Keywords: wingrass
       CPU: Unspecified | Platform: MSWindows
--------------------------+-----------------------

Comment (by martinl):

GRASS 7.7 (trunk) has been modified in r73864 to produce also unversioned
libs on Windows. Can be tested with build no. 357+ from (1) or directly
from OSGeo4W framework (`grass-daily` package).

(1) https://wingrass.fsv.cvut.cz/grass77/x86_64/

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/3718#comment:2>
GRASS GIS <https://grass.osgeo.org>

GDAL · December 26, 2018, 6:06pm

#3718: wingrass: include also unversioned libraries
--------------------------+-----------------------
  Reporter: martinl | Owner: martinl
      Type: task | Status: assigned
  Priority: normal | Milestone: 7.4.4
Component: Packaging | Version: svn-trunk
Resolution: | Keywords: wingrass
       CPU: Unspecified | Platform: MSWindows
--------------------------+-----------------------

Comment (by martinl):

In [changeset:"73865" 73865]:
{{{
#!CommitTicketReference repository="" revision="73865"
remove extra line in Shlib.make, see #3718
}}}

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/3718#comment:3>
GRASS GIS <https://grass.osgeo.org>

GDAL · December 29, 2018, 3:30pm

#3718: wingrass: include also unversioned libraries
--------------------------+-----------------------
  Reporter: martinl | Owner: martinl
      Type: task | Status: assigned
  Priority: normal | Milestone: 7.4.4
Component: Packaging | Version: svn-trunk
Resolution: | Keywords: wingrass
       CPU: Unspecified | Platform: MSWindows
--------------------------+-----------------------
Changes (by martinl):

* Attachment "unversioned-libs.png" added.

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/3718>
GRASS GIS <https://grass.osgeo.org>

GDAL · December 29, 2018, 3:31pm

#3718: wingrass: include also unversioned libraries
--------------------------+-----------------------
  Reporter: martinl | Owner: martinl
      Type: task | Status: assigned
  Priority: normal | Milestone: 7.4.4
Component: Packaging | Version: svn-trunk
Resolution: | Keywords: wingrass
       CPU: Unspecified | Platform: MSWindows
--------------------------+-----------------------

Comment (by martinl):

Result tested with GRASS 7.7svn.

[[Image(unversioned-libs.png, 400px)]]

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/3718#comment:4>
GRASS GIS <https://grass.osgeo.org>

GDAL · January 1, 2019, 6:33pm

#3718: wingrass: include also unversioned libraries
--------------------------+-----------------------
  Reporter: martinl | Owner: martinl
      Type: task | Status: assigned
  Priority: normal | Milestone: 7.4.4
Component: Packaging | Version: svn-trunk
Resolution: | Keywords: wingrass
       CPU: Unspecified | Platform: MSWindows
--------------------------+-----------------------

Comment (by neteler):

May I release or is anything still open here?

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/3718#comment:5>
GRASS GIS <https://grass.osgeo.org>

GDAL · January 1, 2019, 7:24pm

#3718: wingrass: include also unversioned libraries
--------------------------+-----------------------
  Reporter: martinl | Owner: martinl
      Type: task | Status: assigned
  Priority: normal | Milestone: 7.4.4
Component: Packaging | Version: svn-trunk
Resolution: | Keywords: wingrass
       CPU: Unspecified | Platform: MSWindows
--------------------------+-----------------------

Comment (by martinl):

Replying to [comment:5 neteler]:
> May I release or is anything still open here?

yes, still open.

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/3718#comment:6>
GRASS GIS <https://grass.osgeo.org>

GDAL · January 1, 2019, 7:26pm

#3718: wingrass: include also unversioned libraries
--------------------------+-----------------------
  Reporter: martinl | Owner: martinl
      Type: task | Status: assigned
  Priority: normal | Milestone: 7.4.4
Component: Packaging | Version: svn-trunk
Resolution: | Keywords: wingrass
       CPU: Unspecified | Platform: MSWindows
--------------------------+-----------------------

Comment (by martinl):

See related discussion, https://lists.osgeo.org/pipermail/grass-
dev/2018-December/090823.html

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/3718#comment:7>
GRASS GIS <https://grass.osgeo.org>

GDAL · January 1, 2019, 7:54pm

#3718: wingrass: include also unversioned libraries
--------------------------+-----------------------
  Reporter: martinl | Owner: martinl
      Type: task | Status: assigned
  Priority: normal | Milestone: 7.4.4
Component: Packaging | Version: svn-trunk
Resolution: | Keywords: wingrass
       CPU: Unspecified | Platform: MSWindows
--------------------------+-----------------------

Comment (by hellik):

Replying to [comment:7 martinl]:
> See related discussion, https://lists.osgeo.org/pipermail/grass-
dev/2018-December/090823.html

around 7 years ago there was a thread about versioned/unversioned
dlls/libs in winGRASS, see

https://lists.osgeo.org/pipermail/grass-dev/2010-June/050757.html

see mails before and after.

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/3718#comment:8>
GRASS GIS <https://grass.osgeo.org>

GDAL · January 2, 2019, 8:38am

#3718: wingrass: include also unversioned libraries
--------------------------+-----------------------
  Reporter: martinl | Owner: martinl
      Type: task | Status: assigned
  Priority: normal | Milestone: 7.4.4
Component: Packaging | Version: svn-trunk
Resolution: | Keywords: wingrass
       CPU: Unspecified | Platform: MSWindows
--------------------------+-----------------------

Comment (by hellik):

Replying to [comment:7 martinl]:
> See related discussion, https://lists.osgeo.org/pipermail/grass-
dev/2018-December/090823.html

{{{
Is it acceptable solution? If so I will do backport to g76 a g74
branches ASAP.
}}}

what is the reason to backport it to g74?

QGIS 2.18.x reaches its EOL and AFAIU our focus will be on (7.6)/7.8.

it seems there will be a little chance that QGIS 2.18.x/g74 will change.

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/3718#comment:9>
GRASS GIS <https://grass.osgeo.org>

GDAL · January 3, 2019, 9:54pm

#3718: wingrass: include also unversioned libraries
--------------------------+-----------------------
  Reporter: martinl | Owner: martinl
      Type: task | Status: assigned
  Priority: normal | Milestone: 7.6.0
Component: Packaging | Version: svn-trunk
Resolution: | Keywords: wingrass
       CPU: Unspecified | Platform: MSWindows
--------------------------+-----------------------
Changes (by martinl):

* milestone: 7.4.4 => 7.6.0

Comment:

Replying to [comment:9 hellik]:

> it seems there will be a little chance that QGIS 2.18.x/g74 will change.

you are right, changing milestone

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/3718#comment:10>
GRASS GIS <https://grass.osgeo.org>

GDAL · January 3, 2019, 10:04pm

#3718: wingrass: include also unversioned libraries
--------------------------+-----------------------
  Reporter: martinl | Owner: martinl
      Type: task | Status: assigned
  Priority: normal | Milestone: 7.6.0
Component: Packaging | Version: svn-trunk
Resolution: | Keywords: wingrass
       CPU: Unspecified | Platform: MSWindows
--------------------------+-----------------------

Comment (by martinl):

In [changeset:"73905" 73905]:
{{{
#!CommitTicketReference repository="" revision="73905"
Shlib.make: MinGW's 'ln' just copies the file, see #3718
}}}

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/3718#comment:11>
GRASS GIS <https://grass.osgeo.org>

GDAL · January 3, 2019, 10:06pm

#3718: wingrass: include also unversioned libraries
--------------------------+-----------------------
  Reporter: martinl | Owner: martinl
      Type: task | Status: assigned
  Priority: normal | Milestone: 7.6.0
Component: Packaging | Version: svn-trunk
Resolution: | Keywords: wingrass
       CPU: Unspecified | Platform: MSWindows
--------------------------+-----------------------

Comment (by martinl):

Replying to [comment:8 hellik]:
> see mails before and after.

my comment

{{{
> Should the ctypes wrappers be changed to use the versioned library
> name?

Probably yes, just to avoid having copy of unversioned library names.
}}}

sounds nice from GRASS POV. On the other hand would be nice not to break
QGIS GRASS plugin on each GRASS point version

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/3718#comment:12>
GRASS GIS <https://grass.osgeo.org>

GDAL · January 4, 2019, 7:43am

#3718: wingrass: include also unversioned libraries
--------------------------+-----------------------
  Reporter: martinl | Owner: martinl
      Type: task | Status: assigned
  Priority: normal | Milestone: 7.6.0
Component: Packaging | Version: svn-trunk
Resolution: | Keywords: wingrass
       CPU: Unspecified | Platform: MSWindows
--------------------------+-----------------------

Comment (by hellik):

Replying to [comment:12 martinl]:
> Replying to [comment:8 hellik]:
> > see mails before and after.
>
> my comment
>
> {{{
> > Should the ctypes wrappers be changed to use the versioned library
> > name?
>
> Probably yes, just to avoid having copy of unversioned library names.
> }}}
>
> sounds nice from GRASS POV. On the other hand would be nice not to break
QGIS GRASS plugin on each GRASS point version

it's more about

{{{
However: on Windows, the name used to create the DLL (e.g.
libgrass_gis.7.0.svn.dll) is stored in the DLL, and this is preserved
when the file is copied. When linking against a DLL, the name which is
stored in the target (library or executable) is the name stored in the
library, not the name of the file. So linking with -lgrass_gis links
against libgrass_gis.dll, but the resulting executable or library
depends upon libgrass_gis.7.0.svn.dll.
}}}

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/3718#comment:13>
GRASS GIS <https://grass.osgeo.org>

GDAL · January 7, 2019, 8:58pm

#3718: wingrass: include also unversioned libraries
--------------------------+-----------------------
  Reporter: martinl | Owner: martinl
      Type: task | Status: assigned
  Priority: normal | Milestone: 7.6.0
Component: Packaging | Version: svn-trunk
Resolution: | Keywords: wingrass
       CPU: Unspecified | Platform: MSWindows
--------------------------+-----------------------

Comment (by martinl):

ah, I see, reverted in r73921

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/3718#comment:14>
GRASS GIS <https://grass.osgeo.org>

GDAL · January 7, 2019, 9:13pm

#3718: wingrass: include also unversioned libraries
--------------------------+-----------------------
  Reporter: martinl | Owner: martinl
      Type: task | Status: assigned
  Priority: normal | Milestone: 7.6.0
Component: Packaging | Version: svn-trunk
Resolution: | Keywords: wingrass
       CPU: Unspecified | Platform: MSWindows
--------------------------+-----------------------

Comment (by martinl):

Another option would be to remove at least point version from lib names,
see related discussion at https://lists.osgeo.org/pipermail/grass-
dev/2019-January/090920.html

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/3718#comment:15>
GRASS GIS <https://grass.osgeo.org>

GDAL · January 9, 2019, 5:18pm

#3718: wingrass: include also unversioned libraries
--------------------------+-----------------------
  Reporter: martinl | Owner: martinl
      Type: task | Status: closed
  Priority: normal | Milestone: 7.6.0
Component: Packaging | Version: svn-trunk
Resolution: wontfix | Keywords: wingrass
       CPU: Unspecified | Platform: MSWindows
--------------------------+-----------------------
Changes (by martinl):

* status: assigned => closed
* resolution: => wontfix

Comment:

Closing issue as wontfix, see #3728

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/3718#comment:16>
GRASS GIS <https://grass.osgeo.org>