[GRASS-dev] [GRASS GIS] #44: ./configure: cosmetics

GRASS GIS GRASS GIS developer
1

#44: ./configure: cosmetics
---------------------+------------------------------------------------------
Reporter: hamish | Owner: grass-dev@lists.osgeo.org
     Type: task | Status: new
Priority: trivial | Milestone: 6.4.0
Component: default | Version: svn-trunk
Keywords: |
---------------------+------------------------------------------------------
Hi,

for costmetic reasons we should reorder some items in the the yes/no
./configure summary.

Cairo support should be moved up (the rest of the list is in alphabetical
order.

"MacOS App" should be moved up to the top section along with shared libs
and 64bitness.

Q: move LFS and/or NLS to the top section as well?

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/44&gt;
GRASS GIS <http://grass.osgeo.org>
GRASS Geographic Information System (GRASS GIS) - http://grass.osgeo.org/

2

#44: ./configure: cosmetics
----------------------+-----------------------------------------------------
  Reporter: hamish | Owner: grass-dev@lists.osgeo.org
      Type: task | Status: new
  Priority: trivial | Milestone: 6.4.0
Component: default | Version: svn-trunk
Resolution: | Keywords:
----------------------+-----------------------------------------------------
Comment (by neteler):

please go ahead...

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/44#comment:1&gt;
GRASS GIS <http://grass.osgeo.org>
GRASS Geographic Information System (GRASS GIS) - http://grass.osgeo.org/

3

#44: ./configure: cosmetics
----------------------+-----------------------------------------------------
  Reporter: hamish | Owner: grass-dev@lists.osgeo.org
      Type: task | Status: new
  Priority: trivial | Milestone: 6.4.0
Component: default | Version: svn-trunk
Resolution: | Keywords:
----------------------+-----------------------------------------------------
Comment (by hamish):

A patch for configure.in is attached to the bug report, but I don't know
the exact recipe to rebuild configure with autoconf 2.13. (include that in
the config.in header comments?)

Also the patch lacks indenting cosmetics for MacOS App in the top section,
it'll be spaced an extra char to the right. I don't know how to fix that.

Hamish

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/44#comment:2&gt;
GRASS GIS <http://grass.osgeo.org>
GRASS Geographic Information System (GRASS GIS) - http://grass.osgeo.org/

4

#44: ./configure: cosmetics
----------------------+-----------------------------------------------------
  Reporter: hamish | Owner: grass-dev@lists.osgeo.org
      Type: task | Status: new
  Priority: trivial | Milestone: 6.4.0
Component: default | Version: svn-trunk
Resolution: | Keywords:
----------------------+-----------------------------------------------------
Comment (by neteler):

Just run autoconf-2.13. I do it like this:

{{{
[neteler@localhost grass63]$ patch -p0 < /tmp/config.in_reorder.diff
patching file configure.in

[neteler@localhost grass63]$ autoconf-2.13
configure.in:587: warning: Cannot check for file existence when cross
compiling
[neteler@localhost grass63]$
}}}

Indent-fixed patch uploaded.

Markus

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/44#comment:3&gt;
GRASS GIS <http://grass.osgeo.org>
GRASS Geographic Information System (GRASS GIS) - http://grass.osgeo.org/

5

#44: ./configure: cosmetics
----------------------+-----------------------------------------------------
  Reporter: hamish | Owner: grass-dev@lists.osgeo.org
      Type: task | Status: new
  Priority: trivial | Milestone: 6.4.0
Component: default | Version: svn-trunk
Resolution: | Keywords:
----------------------+-----------------------------------------------------
Comment (by martinl):

Q: Should I wait with changes in python/wxwidgets or just to commit to SVN
now?

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/44#comment:4&gt;
GRASS GIS <http://grass.osgeo.org>
GRASS Geographic Information System (GRASS GIS) - http://grass.osgeo.org/

6

#44: ./configure: cosmetics
----------------------+-----------------------------------------------------
  Reporter: hamish | Owner: grass-dev@lists.osgeo.org
      Type: task | Status: new
  Priority: trivial | Milestone: 6.4.0
Component: default | Version: svn-trunk
Resolution: | Keywords:
----------------------+-----------------------------------------------------
Comment (by martinl):

Sorry, I forgot to put reference -- #38

Martin

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/44#comment:5&gt;
GRASS GIS <http://grass.osgeo.org>
GRASS Geographic Information System (GRASS GIS) - http://grass.osgeo.org/

7

#44: ./configure: cosmetics
----------------------+-----------------------------------------------------
  Reporter: hamish | Owner: grass-dev@lists.osgeo.org
      Type: task | Status: new
  Priority: trivial | Milestone: 6.4.0
Component: default | Version: svn-trunk
Resolution: | Keywords:
----------------------+-----------------------------------------------------
Comment (by hamish):

Markus:
> Just run autoconf-2.13. I do it like this:
{{{
$ patch -p0 < /tmp/config.in_reorder.diff
...
$ autoconf-2.13
}}}

> Indent-fixed patch uploaded.

Ok, that's both very easy. Two problems-

- I notice that after running autoconf2.13 there is an extra reference to
*.$ac_ext,
??? should I have run 'make distclean' before autoconf2.13 or do our
autoconf's differ?

{{{
--- configure (revision 30045)
+++ configure (working copy)
@@ -1014,7 +1014,7 @@
    if { (eval echo configure:1015: \"$ac_link\") 1>&5; (eval $ac_link)
2>&5; }; then
      for file in conftest.*; do
        case $file in
- *.c | *.o | *.obj) ;;
+ *.$ac_ext | *.c | *.o | *.obj) ;;
        *) ac_cv_exeext=`echo $file | sed -e s/conftest//` ;;
        esac
      done
}}}

- top section indenting now lines up but "yes|no" part for MacOSX App
doesn't.

{{{
   Building shared libraries: yes
   64bit support: no
   OpenGL platform: X11
   MacOSX application: no

   NVIZ: yes

   BLAS support: no
   C++ support: yes
   Cairo support: yes
   DWG support: no
}}}

Martin:
> Q: Should I wait with changes in python/wxwidgets or just to commit to
SVN now?
> (#38)

because it's so trivial I don't see a reason not to combine them, but on
the other hand this patch does not cause more than a few lines of change
in configure (typically autoconf causes a huge patch) so it wouldn't be
inefficient to do it by itself. shrug.

Outstanding question:
> > Q: move LFS and/or NLS to the top section as well?

Hamish

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/44#comment:6&gt;
GRASS GIS <http://grass.osgeo.org>
GRASS Geographic Information System (GRASS GIS) - http://grass.osgeo.org/

8

#44: ./configure: cosmetics
----------------------+-----------------------------------------------------
  Reporter: hamish | Owner: grass-dev@lists.osgeo.org
      Type: task | Status: closed
  Priority: trivial | Milestone: 6.4.0
Component: default | Version: svn-trunk
Resolution: fixed | Keywords:
----------------------+-----------------------------------------------------
Changes (by neteler):

  * status: new => closed
  * resolution: => fixed

Comment:

Submitted.

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/44#comment:7&gt;
GRASS GIS <http://grass.osgeo.org>
GRASS Geographic Information System (GRASS GIS) - http://grass.osgeo.org/