[GRASS-dev] [GRASS GIS] #54: g.remove mixes raster and vector maps: "Remove reclassed map first"

GDAL · February 19, 2008, 5:45am

#54: g.remove mixes raster and vector maps: "Remove reclassed map first"
---------------------+------------------------------------------------------
Reporter: neteler | Owner: grass-dev@lists.osgeo.org
Type: defect | Status: new
Priority: major | Milestone: 6.4.0
Component: default | Version: unspecified
Keywords: |
---------------------+------------------------------------------------------
A strange bug appeared: Trying to remove a vector map, g.remove gets
confused with a non-exiting reclass map

{{{
GRASS 6.3.svn (pat):~ > g.remove
vect=lst_20050101_avg,lst_20050101_avg2,lst_200501_avg_filt
WARNING: [lst_20050101_avg@modisLSTzanzara] is a base map. Remove
reclassed
map first: MASK@modisLSTzanzara
Removing vector <lst_20050101_avg2>
WARNING: [lst_200501_avg_filt@modisLSTzanzara] is a base map. Remove
reclassed map first: MASK@modisLSTzanzara

GRASS 6.3.svn (pat):~ > g.remove vect=lst_20050101_avg
WARNING: [lst_20050101_avg@modisLSTzanzara] is a base map. Remove
reclassed
map first: MASK@modisLSTzanzara

GRASS 6.3.svn (pat):~ > g.list rast | grep lst_20050101_avg
lst_20030114_avg lst_20050101_avg
lst_20030115_avg lst_20050101_avg_lstmodel

GRASS 6.3.svn (pat):~ > g.list vect | grep lst_
lst_20050101_avg lst_200501_avg_filt

GRASS 6.3.svn (pat):~ > r.info lst_20050101_avg | grep generated
| generated by r.series
|

GRASS 6.3.svn (pat):~ > g.gisenv
GISDBASE=/home/neteler/grassdata
LOCATION_NAME=pat
MAPSET=modisLSTzanzara
DEBUG=0
GRASS_GUI=text
MONITOR=x0
}}}

The problem seems to be in source:grass/trunk/general/manage/cmd/remove.c
(line 83) where it should not enter. Fix appreciated..

Markus

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/54>
GRASS GIS <http://grass.osgeo.org>
GRASS Geographic Information System (GRASS GIS) - http://grass.osgeo.org/

Glynn_Clements1 · February 20, 2008, 3:48am

GRASS GIS wrote:

#54: g.remove mixes raster and vector maps: "Remove reclassed map first"
---------------------+------------------------------------------------------
Reporter: neteler | Owner: grass-dev@lists.osgeo.org
     Type: defect | Status: new
Priority: major | Milestone: 6.4.0
Component: default | Version: unspecified
Keywords: |
---------------------+------------------------------------------------------
A strange bug appeared: Trying to remove a vector map, g.remove gets
confused with a non-exiting reclass map

{{{
GRASS 6.3.svn (pat):~ > g.remove
vect=lst_20050101_avg,lst_20050101_avg2,lst_200501_avg_filt
WARNING: [lst_20050101_avg@modisLSTzanzara] is a base map. Remove
reclassed
          map first: MASK@modisLSTzanzara
Removing vector <lst_20050101_avg2>
WARNING: [lst_200501_avg_filt@modisLSTzanzara] is a base map. Remove
          reclassed map first: MASK@modisLSTzanzara

GRASS 6.3.svn (pat):~ > g.remove vect=lst_20050101_avg
WARNING: [lst_20050101_avg@modisLSTzanzara] is a base map. Remove
reclassed
          map first: MASK@modisLSTzanzara

GRASS 6.3.svn (pat):~ > g.list rast | grep lst_20050101_avg
lst_20030114_avg lst_20050101_avg
lst_20030115_avg lst_20050101_avg_lstmodel

GRASS 6.3.svn (pat):~ > g.list vect | grep lst_
lst_20050101_avg lst_200501_avg_filt

GRASS 6.3.svn (pat):~ > r.info lst_20050101_avg | grep generated
  | generated by r.series
|

GRASS 6.3.svn (pat):~ > g.gisenv
GISDBASE=/home/neteler/grassdata
LOCATION_NAME=pat
MAPSET=modisLSTzanzara
DEBUG=0
GRASS_GUI=text
MONITOR=x0
}}}

The problem seems to be in source:grass/trunk/general/manage/cmd/remove.c
(line 83) where it should not enter. Fix appreciated..

Can you test the attached patch?

--
Glynn Clements <glynn@gclements.plus.com>

(attachments)

g.remove-reclass.diff (4.39 KB)

neteler · February 24, 2008, 9:12pm

Glynn

the suggested patch works. Please submit...

thanks
Markus

On Wed, Feb 20, 2008 at 4:48 AM, Glynn Clements
<glynn@gclements.plus.com> wrote:

GRASS GIS wrote:

> #54: g.remove mixes raster and vector maps: "Remove reclassed map first"
> ---------------------+------------------------------------------------------
> Reporter: neteler | Owner: grass-dev@lists.osgeo.org
> Type: defect | Status: new
> Priority: major | Milestone: 6.4.0
> Component: default | Version: unspecified
> Keywords: |
> ---------------------+------------------------------------------------------
> A strange bug appeared: Trying to remove a vector map, g.remove gets
> confused with a non-exiting reclass map
>
> {{{
> GRASS 6.3.svn (pat):~ > g.remove
> vect=lst_20050101_avg,lst_20050101_avg2,lst_200501_avg_filt
> WARNING: [lst_20050101_avg@modisLSTzanzara] is a base map. Remove
> reclassed
> map first: MASK@modisLSTzanzara
> Removing vector <lst_20050101_avg2>
> WARNING: [lst_200501_avg_filt@modisLSTzanzara] is a base map. Remove
> reclassed map first: MASK@modisLSTzanzara
>
> GRASS 6.3.svn (pat):~ > g.remove vect=lst_20050101_avg
> WARNING: [lst_20050101_avg@modisLSTzanzara] is a base map. Remove
> reclassed
> map first: MASK@modisLSTzanzara
>
> GRASS 6.3.svn (pat):~ > g.list rast | grep lst_20050101_avg
> lst_20030114_avg lst_20050101_avg
> lst_20030115_avg lst_20050101_avg_lstmodel
>
> GRASS 6.3.svn (pat):~ > g.list vect | grep lst_
> lst_20050101_avg lst_200501_avg_filt
>
> GRASS 6.3.svn (pat):~ > r.info lst_20050101_avg | grep generated
> | generated by r.series
> |
>
> GRASS 6.3.svn (pat):~ > g.gisenv
> GISDBASE=/home/neteler/grassdata
> LOCATION_NAME=pat
> MAPSET=modisLSTzanzara
> DEBUG=0
> GRASS_GUI=text
> MONITOR=x0
> }}}
>
> The problem seems to be in source:grass/trunk/general/manage/cmd/remove.c
> (line 83) where it should not enter. Fix appreciated..

Can you test the attached patch?

--
Glynn Clements <glynn@gclements.plus.com>

GDAL · January 15, 2011, 9:36pm

#54: g.remove mixes raster and vector maps: "Remove reclassed map first"
-------------------------+--------------------------------------------------
Reporter: neteler | Owner: grass-dev@…
Type: defect | Status: new
Priority: major | Milestone: 6.4.0
Component: Default | Version: unspecified
Keywords: g.remove | Platform: Unspecified
Cpu: Unspecified |
-------------------------+--------------------------------------------------
Changes (by hamish):

  * keywords: => g.remove
  * platform: => Unspecified
  * cpu: => Unspecified

--
Ticket URL: <https://trac.osgeo.org/grass/ticket/54#comment:1>
GRASS GIS <http://grass.osgeo.org>

GDAL · January 16, 2011, 6:27pm

#54: g.remove mixes raster and vector maps: "Remove reclassed map first"
-------------------------+--------------------------------------------------
Reporter: neteler | Owner: grass-dev@…
Type: defect | Status: new
Priority: major | Milestone: 6.4.0
Component: Default | Version: unspecified
Keywords: g.remove | Platform: Unspecified
Cpu: Unspecified |
-------------------------+--------------------------------------------------

Comment(by neteler):

Glynn Clements to grass-dev, 2/20/08

Can you test the attached patch?

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/54#comment:2>
GRASS GIS <http://grass.osgeo.org>

GDAL · March 21, 2011, 8:21am

#54: g.remove mixes raster and vector maps: "Remove reclassed map first"
-------------------------+--------------------------------------------------
Reporter: neteler | Owner: grass-dev@…
Type: defect | Status: new
Priority: major | Milestone: 6.4.0
Component: Default | Version: unspecified
Keywords: g.remove | Platform: Unspecified
Cpu: Unspecified |
-------------------------+--------------------------------------------------

Comment(by neteler):

I wonder if this patch is still relevant since a reclass map bug was fixed
in r45699.

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/54#comment:3>
GRASS GIS <http://grass.osgeo.org>

GDAL · August 19, 2012, 11:44am

#54: g.remove mixes raster and vector maps: "Remove reclassed map first"
--------------------------+-------------------------------------------------
  Reporter: neteler | Owner: grass-dev@…
      Type: defect | Status: closed
  Priority: major | Milestone: 6.4.0
Component: Default | Version: unspecified
Resolution: fixed | Keywords: g.remove
  Platform: Unspecified | Cpu: Unspecified
--------------------------+-------------------------------------------------
Changes (by neteler):

* status: new => closed
* resolution: => fixed

Comment:

No complaints without the patch, it seems that r45699 fixed it. Closing.

--
Ticket URL: <http://trac.osgeo.org/grass/ticket/54#comment:4>
GRASS GIS <http://grass.osgeo.org>