[GRASS-dev] indent tool bug - Re: [GRASS-SVN] r44565 - grass-addons/postscript/ps.output

GRASS GRASS developer
1

Hi,

please use tools/grass_indent.sh only with a working version of "indent":

On Thu, Dec 9, 2010 at 12:19 AM, <svn_grass@osgeo.org> wrote:

Author: hamish
Date: 2010-12-08 15:19:08 -0800 (Wed, 08 Dec 2010)
New Revision: 44565

Modified:
grass-addons/postscript/ps.output/cat_val.c

...

Log:
run tools/grass_indent.sh

Modified: grass-addons/postscript/ps.output/cat_val.c

--- grass-addons/postscript/ps.output/cat_val.c 2010-12-08 22:53:50 UTC (rev 44564)
+++ grass-addons/postscript/ps.output/cat_val.c 2010-12-08 23:19:08 UTC (rev 44565)
@@ -16,25 +16,30 @@
static char catval_str[128];

/* LOAD CAT_VAL */
-int load_catval_array(VECTOR * vector, const char *colname, dbCatValArray * cvarr)
+int load_catval_array(VECTOR * vector, const char *colname,
+ dbCatValArray * cvarr)
{
int n_records;
+
struct field_info *Fi;
+
dbDriver *driver;

...

this is the broken version which introduces nonsense new lines between
the variables:
https://savannah.gnu.org/bugs/index.php?27036

Apparently Debian has fixed it for 2.2.11-1:
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=485764

Please upgrade to indent 2.2.11-1.

Markus

2

Markus wrote:

please use tools/grass_indent.sh only with a working
version of "indent":

...

this is the broken version which introduces nonsense new
lines between the variables:
https://savannah.gnu.org/bugs/index.php?27036

Apparently Debian has fixed it for 2.2.11-1:
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=485764

Please upgrade to indent 2.2.11-1.

Interesting. I saw a couple of those newlines but didn't think
much of them. local_proto.h was a huge mess; now fixed in svn.
Thanks for the tip.

fwiw, it is broken in Debian/Lenny, but fixed in Squeeze.
Broken in Ubuntu/karmic, lucid LTS, and maverick, but fixed in 11.04 natty.

Hamish