[GRASS-dev] r3.univar and r.univar

GRASS GIS GRASS GIS developer
1

Dear devs,
i have merged the code of r.univar and r3.univar.
Please test the new modules and if no errors occure, i will replace
the current r.univar code with the new one.

The code:
http://www-pool.math.tu-berlin.de/~soeren/grass/modules/r3.univar.tar.bz2
includes r3.univar and r.univar.

Important note:
I have used a heapsort algorithm based on code from the german wikipedia:
http://de.wikipedia.org/wiki/Heapsort

The heapsort functions are located in a separate file
including a note which references the german wikipedia site.

Im not sure if i can use this code in a GPL software?

Best regards
Soeren

2

Hi,

2007/2/27, Sören Gebbert <soerengebbert@gmx.de>:

Dear devs,
i have merged the code of r.univar and r3.univar.
Please test the new modules and if no errors occure, i will replace
the current r.univar code with the new one.

The code:
http://www-pool.math.tu-berlin.de/~soeren/grass/modules/r3.univar.tar.bz2
includes r3.univar and r.univar.

I slightly tested the new r.univar/r3.univar module, no errors
occurred. From my point of view, the current r.univar code can be
replaced.

Martin

--
Martin Landa <landa.martin@gmail.com> * http://gama.fsv.cvut.cz/~landa *

3

On 2/27/07, Sören Gebbert <soerengebbert@gmx.de> wrote:
[...]

The heapsort functions are located in a separate file
including a note which references the german wikipedia site.

Im not sure if i can use this code in a GPL software?

AFAICT you can, but the code itself is GFDL-licensed by the Wikipedia
article author. You could alternatively use GSL's heapsort which is
GPLed:

http://sourceware.org/cgi-bin/cvsweb.cgi/gsl/sort/sortvec.c?rev=1.5&content-type=text/x-cvsweb-markup&cvsroot=gsl

BTW I found that using code.google.com and searching for 'heapsort license:gpl'

Daniel.

--
-- Daniel Calvelo Aros

4

Hi,
i had an eye on this code bevor,
but the wikipedia implementation was a bit nicer. :wink:

So i have chosen the wiki code.

But i recently found a gpl version of heapsort
and i think will use this one:
http://www.fh-augsburg.de/informatik/vorlesungen/c_cplus/tutorial/cyris/c-kurs16.htm

Best regards
Soeren

Daniel Calvelo schrieb:

On 2/27/07, Sören Gebbert <soerengebbert@gmx.de> wrote:
[...]

The heapsort functions are located in a separate file
including a note which references the german wikipedia site.

Im not sure if i can use this code in a GPL software?

AFAICT you can, but the code itself is GFDL-licensed by the Wikipedia
article author. You could alternatively use GSL's heapsort which is
GPLed:

http://sourceware.org/cgi-bin/cvsweb.cgi/gsl/sort/sortvec.c?rev=1.5&content-type=text/x-cvsweb-markup&cvsroot=gsl

BTW I found that using code.google.com and searching for 'heapsort license:gpl'

Daniel.

5

Hi,
thanks for testing!

Because of the heapsort code issue, i have implemented a new version of r3/r.univar.
The heapsort code is now based on a GPL implementation which i have found in the net and it seems to work.

http://www.fh-augsburg.de/informatik/vorlesungen/c_cplus/tutorial/cyris/c-kurs16.htm

The original author of the heapsort code is noticed in the code.

The latest version is available here:
http://www-pool.math.tu-berlin.de/~soeren/grass/modules/r3.univar.tar.bz2

Best regards
Soeren

Martin Landa schrieb:

Hi,

2007/2/27, Sören Gebbert <soerengebbert@gmx.de>:

Dear devs,
i have merged the code of r.univar and r3.univar.
Please test the new modules and if no errors occure, i will replace
the current r.univar code with the new one.

The code:
http://www-pool.math.tu-berlin.de/~soeren/grass/modules/r3.univar.tar.bz2
includes r3.univar and r.univar.

I slightly tested the new r.univar/r3.univar module, no errors
occurred. From my point of view, the current r.univar code can be
replaced.

Martin