There's a missing " quote at the end of line 110. One thousand times lucky this was in a commented out part!!
Hamish
ps- curly brackets do not work for quoting strings or paths, only variable names. if used when not actually needed it fools students of the code into thinking that they will be safe to use instead of real "quotes", and so the misconception & breakage gets propagated on and on. This is especially important for things touching MS Windows where spaces in the path names are common and the future reader may not be a veteran Bourne coder.
it has some background, I spent some days with creating a new
up-to-date OSGEO4W packages for produce environment (`msys`) and
building environment (`mingw`). Disabling `pwd -W` turned to
reasonable even before releasing. When spending time on that and other
fucking Windows issues I took liberty to comment it at least.
There's a missing " quote at the end of line 110. One thousand times lucky this was in a commented out part!!
re r57291, it's not safe to modify core files after the last RC
Martin:
but sure, you are right. It was not a good idea.
but seems no harm done
It's an interesting conflict -- on one side if we know a fix we wouldn't want
to release without it, on the other side is the law of unintended consequences
resetting the testing clock to zero after any change.
Then add to that taking good advantage of the focused productivity of everyone
pushing to get the release out the door while at the same time not wanting
to raise any dust into the air just prior to release.
