[GRASS5] please commit indent by itself

GRASS GIS GRASS GIS developer
1

[GRASS-CVS] markus: grass6/vector/v.out.ascii b2a.c,1.4,1.5
head.c,1.2,1.3 local_proto.h,1.2,1.3 out.c,1.5,1.6

Update of /grassrepository/grass6/vector/v.out.ascii
In directory doto:/tmp/cvs-serv15591

Modified Files:
  b2a.c head.c local_proto.h out.c
Log Message:
[...] added option dp to truncate the float output of point coordinates;
added localisation; code prettified with indent

If you commit an indent change at the same time as other changes, it
makes it very hard to use diff to see what the code changes really were,
chase bugs, etc. Please commit indent changes by themselves. It's also
a good idea to list the indent switches used in the CVS log so if
someone wants to use diff they can.

Suggested indent rules are not in the SUBMITTING file; shall we ask for
these? (same or similar to those scattered throughout the changelog)

$ indent -nbad -bap -bbb -nbbo -nbc -br -bli1 -bls -cbi0 -ncdb -nce \
-ci4 -cli0 -ncs -d0 -di0 -fc1 -nfca -hnl -i4 -ip4 -l80 -lc80 -lp -npcs \
-pi4 -nprs -npsl -sbi0 -sc -nsob -ss -ts8 main.c

cheers,
Hamish

2

On Wed, Mar 01, 2006 at 09:24:55PM +1300, Hamish wrote:

[GRASS-CVS] markus: grass6/vector/v.out.ascii b2a.c,1.4,1.5
head.c,1.2,1.3 local_proto.h,1.2,1.3 out.c,1.5,1.6

Update of /grassrepository/grass6/vector/v.out.ascii
In directory doto:/tmp/cvs-serv15591

Modified Files:
  b2a.c head.c local_proto.h out.c
Log Message:
[...] added option dp to truncate the float output of point coordinates;
added localisation; code prettified with indent

Hamish,

If you commit an indent change at the same time as other changes, it
makes it very hard to use diff to see what the code changes really were,
chase bugs, etc. Please commit indent changes by themselves. It's also
a good idea to list the indent switches used in the CVS log so if
someone wants to use diff they can.

you are absolutely right.
Sorry for that.

Suggested indent rules are not in the SUBMITTING file; shall we ask for
these? (same or similar to those scattered throughout the changelog)

$ indent -nbad -bap -bbb -nbbo -nbc -br -bli1 -bls -cbi0 -ncdb -nce \
-ci4 -cli0 -ncs -d0 -di0 -fc1 -nfca -hnl -i4 -ip4 -l80 -lc80 -lp -npcs \
-pi4 -nprs -npsl -sbi0 -sc -nsob -ss -ts8 main.c

Please add them to SUBMITTING. If anyone disagrees, we can modify
there again.

Markus