GSoC pgRouting first period communications

pgRouting pgrouting-dev
21

Reply to:

Dear @cvvergara ,

I’m truly sorry for the trouble I caused.

I believe I might have misunderstood what @robe said. I clearly remember what you mentioned in the meeting — not to do force-pushes and not to fetch from pgrouting — and I really took those instructions seriously. However, when I was dealing with some leftover issues from last week, I felt that I had to do both a force-push and a fetch from pgrouting in order to move forward.

Even though I hesitated that time, I thought maybe I could give it a try and see what happens, and then try to fix things if anything went wrong. That was my mistake, and I sincerely apologize for not being more careful and for going against your guidance.

I’ve now removed the pgrouting remote from my local repo again, and I won’t force-push again in the future.

Sorry again for the trouble, and thank you for your patience in fixing the pull request.

Best regards,

wifi

22

Hello Everyone,

I hope you all are doing well. I wanted to inform you that I will not be able to attend today’s meeting as I am currently traveling back home and will be reaching by midnight.

Apologies for any inconvenience caused. Please feel free to share any important updates, and I will make sure to catch up accordingly.

23

Hello mentors, I’m facing this issue after successfully compiling my code.

 bash run.sh
pgRouting VERSION 4.0.0
------------------------------------
------------------------------------
Compiling with G++-
------------------------------------
-- CMAKE_BUILD_TYPE Debug
-- DOXYGEN_MINIMUM_VERSION=1.7
-- SPHINX_MINIMUM_VERSION=4.0
-- POSTGRESQL_MINIMUM_VERSION=13.0.0
-- BOOST_MINIMUM_VERSION=1.56.0
-- POSTGIS_MINIMUM_VERSION=3.0.0
-- POSTGRESQL_PG_CONFIG is /usr/bin/pg_config
-- POSTGRESQL_EXECUTABLE is /usr/lib/postgresql/17/bin/postgres
-- POSTGRESQL_VERSION_STRING in FindPostgreSQL.cmake is PostgreSQL 17.0 (Debian 17.0-1+b2)
-- POSTGRESQL_INCLUDE_DIR: /usr/include/postgresql/17/server
-- POSTGRESQL_LIBRARIES: /usr/lib/x86_64-linux-gnu
-- POSTGRESQL_VERSION_STRING=PostgreSQL 17.0 (Debian 17.0-1+b2)
-- POSTGRESQL_VERSION=17.0
-- PGSQL_VERSION=17000
-- PGSQL_VERSION=17000
-- LIBRARY_INSTALL_PATH /usr/lib/postgresql/17/lib
-- Developers documentation.
-- Could NOT find Doxygen (missing: DOXYGEN_EXECUTABLE) (Required is at least version "1.7")
-- PROJECT_DOC_TARGETS = html;latex
-- PROJECT_BUILD_LANGUAGES = en
-- SPHINXINTL_LANGUAGE = en
-- Checking for package 'Sphinx'
-- SPHINX_VERSION sphinx-build 7.4.7
-- SPHINX_VERSION 7.4.7
-- PGR_DOCUMENTATION_BUILD_DIR = /home/bipasha/GSoC-pgRouting/build/doc
-- Configuring done (1.1s)
-- Generating done (0.2s)
-- Build files have been written to: /home/bipasha/GSoC-pgRouting/build
[  0%] Built target legacy
[  1%] Built target allpairs
[  2%] Built target metrics
[  3%] Built target astar
[  5%] Built target bdDijkstra
[  6%] Built target tsp
[ 10%] Built target ksp
[ 10%] Built target bdAstar
[ 17%] Built target withPoints
[ 20%] Built target common
[ 22%] Built target dijkstra
[ 24%] Built target contraction
[ 32%] Built target pickDeliver
[ 33%] Built target driving_distance
[ 38%] Built target trsp
[ 40%] Built target lineGraph
[ 40%] Building C object src/version/CMakeFiles/version.dir/version.c.o
[ 46%] Built target max_flow
[ 47%] Built target mincut
[ 47%] Built target chinese
[ 48%] Built target dagShortestPath
[ 49%] Built target topologicalSort
[ 51%] Built target transitiveClosure
[ 52%] Built target bellman_ford
[ 53%] Built target traversal
[ 56%] Built target spanningTree
[ 58%] Built target breadthFirstSearch
[ 59%] Built target planar
[ 60%] Built target extension_file
[ 65%] Built target cpp_common
[ 66%] Built target dominator
[ 70%] Built target circuits
[ 70%] Built target coloring
[ 77%] Built target components
[ 80%] Built target ordering
[100%] Built target update_files
[100%] Built target version
[100%] Linking CXX shared library lib/libpgrouting-4.0.so
[100%] Built target pgrouting-4.0
[sudo] password for bipasha:
[  1%] Built target metrics
[  7%] Built target common
[ 10%] Built target dijkstra
[ 10%] Built target legacy
[ 11%] Built target allpairs
[ 12%] Built target astar
[ 13%] Built target driving_distance
[ 16%] Built target ksp
[ 18%] Built target tsp
[ 19%] Built target bdAstar
[ 20%] Built target bdDijkstra
[ 25%] Built target trsp
[ 31%] Built target max_flow
[ 33%] Built target contraction
[ 41%] Built target pickDeliver
[ 44%] Built target withPoints
[ 46%] Built target lineGraph
[ 53%] Built target components
[ 55%] Built target bellman_ford
[ 60%] Built target cpp_common
[ 61%] Built target dagShortestPath
[ 62%] Built target chinese
[ 65%] Built target spanningTree
[ 65%] Built target mincut
[ 65%] Built target version
[ 66%] Built target topologicalSort
[ 67%] Built target transitiveClosure
[ 69%] Built target breadthFirstSearch
[ 70%] Built target traversal
[ 73%] Built target coloring
[ 74%] Built target planar
[ 75%] Built target dominator
[ 78%] Built target ordering
[ 79%] Built target circuits
[ 79%] Built target pgrouting-4.0
[ 80%] Built target extension_file
[100%] Built target update_files
Install the project...
-- Install configuration: "Debug"
-- Installing: /usr/lib/postgresql/17/lib/libpgrouting-4.0.so
-- Up-to-date: /usr/share/postgresql/17/extension/pgrouting--3.8.0--4.0.0.sql
-- Up-to-date: /usr/share/postgresql/17/extension/pgrouting--3.7.3--4.0.0.sql
-- Up-to-date: /usr/share/postgresql/17/extension/pgrouting--3.7.2--4.0.0.sql
-- Up-to-date: /usr/share/postgresql/17/extension/pgrouting--3.7.1--4.0.0.sql
-- Up-to-date: /usr/share/postgresql/17/extension/pgrouting--3.7.0--4.0.0.sql
-- Up-to-date: /usr/share/postgresql/17/extension/pgrouting--3.6.3--4.0.0.sql
-- Up-to-date: /usr/share/postgresql/17/extension/pgrouting--3.6.2--4.0.0.sql
-- Up-to-date: /usr/share/postgresql/17/extension/pgrouting--3.6.1--4.0.0.sql
-- Up-to-date: /usr/share/postgresql/17/extension/pgrouting--3.6.0--4.0.0.sql
-- Up-to-date: /usr/share/postgresql/17/extension/pgrouting--3.5.1--4.0.0.sql
-- Up-to-date: /usr/share/postgresql/17/extension/pgrouting--3.5.0--4.0.0.sql
-- Up-to-date: /usr/share/postgresql/17/extension/pgrouting--3.4.2--4.0.0.sql
-- Up-to-date: /usr/share/postgresql/17/extension/pgrouting--3.4.1--4.0.0.sql
-- Up-to-date: /usr/share/postgresql/17/extension/pgrouting--3.4.0--4.0.0.sql
-- Up-to-date: /usr/share/postgresql/17/extension/pgrouting--3.3.5--4.0.0.sql
-- Up-to-date: /usr/share/postgresql/17/extension/pgrouting--3.3.4--4.0.0.sql
-- Up-to-date: /usr/share/postgresql/17/extension/pgrouting--3.3.3--4.0.0.sql
-- Up-to-date: /usr/share/postgresql/17/extension/pgrouting--3.3.2--4.0.0.sql
-- Up-to-date: /usr/share/postgresql/17/extension/pgrouting--3.3.1--4.0.0.sql
-- Up-to-date: /usr/share/postgresql/17/extension/pgrouting--3.3.0--4.0.0.sql
-- Up-to-date: /usr/share/postgresql/17/extension/pgrouting--3.2.2--4.0.0.sql
-- Up-to-date: /usr/share/postgresql/17/extension/pgrouting--3.2.1--4.0.0.sql
-- Up-to-date: /usr/share/postgresql/17/extension/pgrouting--3.2.0--4.0.0.sql
-- Up-to-date: /usr/share/postgresql/17/extension/pgrouting--3.1.4--4.0.0.sql
-- Up-to-date: /usr/share/postgresql/17/extension/pgrouting--3.1.3--4.0.0.sql
-- Up-to-date: /usr/share/postgresql/17/extension/pgrouting--3.1.2--4.0.0.sql
-- Up-to-date: /usr/share/postgresql/17/extension/pgrouting--3.1.1--4.0.0.sql
-- Up-to-date: /usr/share/postgresql/17/extension/pgrouting--3.1.0--4.0.0.sql
-- Up-to-date: /usr/share/postgresql/17/extension/pgrouting--3.0.6--4.0.0.sql
-- Up-to-date: /usr/share/postgresql/17/extension/pgrouting--3.0.5--4.0.0.sql
-- Up-to-date: /usr/share/postgresql/17/extension/pgrouting--3.0.4--4.0.0.sql
-- Up-to-date: /usr/share/postgresql/17/extension/pgrouting--3.0.3--4.0.0.sql
-- Up-to-date: /usr/share/postgresql/17/extension/pgrouting--3.0.2--4.0.0.sql
-- Up-to-date: /usr/share/postgresql/17/extension/pgrouting--3.0.1--4.0.0.sql
-- Up-to-date: /usr/share/postgresql/17/extension/pgrouting--3.0.0--4.0.0.sql
-- Up-to-date: /usr/share/postgresql/17/extension/pgrouting--2.6.3--4.0.0.sql
-- Up-to-date: /usr/share/postgresql/17/extension/pgrouting--2.6.2--4.0.0.sql
-- Up-to-date: /usr/share/postgresql/17/extension/pgrouting--2.6.1--4.0.0.sql
-- Up-to-date: /usr/share/postgresql/17/extension/pgrouting--2.6.0--4.0.0.sql
-- Up-to-date: /usr/share/postgresql/17/extension/pgrouting--4.0.0.sql
-- Up-to-date: /usr/share/postgresql/17/extension/pgrouting.control
--------------------------------------------
Execute documentation queries
--------------------------------------------
RUNNING: doc_queries_generator.pl -alg docqueries/ordering -pgport 5432
Operative system found: linux
psql: error: connection to server on socket "/var/run/postgresql/.s.PGSQL.5432" failed: No such file or directory
        Is the server running locally and accepting connections on that socket?
Use of uninitialized value $pg in substitution (s///) at tools/testers/doc_queries_generator.pl line 493.
Use of uninitialized value $dbver in concatenation (.) or string at tools/testers/doc_queries_generator.pl line 382.

    Unsupported postgreSQL version
    Minimum requierment is 12 version
    Use -force to force the tests

How do I solve this? my psql version is 17 too.

24

Hello @bipashabg
I tried to see the action that checks the queries after you pushed

Please execute the following:

bash tools/release-scripts/get_signatures.sh

commit.

I am running with the debug flag:

RUNNING: doc_queries_generator.pl -alg docqueries/ordering -level DEBUG3 -pgport 5432
The level DEBUG3
Operative system found: linux
DROP EXTENSION
ERROR:  function pgr_sloanordering(text, bigint, bigint) does not exist
ERROR:  function pgr_version() does not exist
LINE 1: select pgr_version()

but basically I am getting the same error from the actions

To fix the error I get change:

COMMENT ON FUNCTION pgr_sloanOrdering(TEXT, BIGINT, BIGINT)

to

COMMENT ON FUNCTION pgr_sloanOrdering(<List of input parameter's types>)

Where you need to figure what goes there :slight_smile:

After fixing please commit and push and then go to the actions and focus on check-queries action.
(aka let the actions be your computer)

We will worry about fixing your problem on Monday meeting, you can always go to the actions to see the progress of your execution.

prepare yourself for fixing the problem:

Without the need to recompile you can run the script:

tools/testers/doc_queries_generator.pl -help

Which wont help much in your current problem, but basically for any command you can ask for help on the command.

Then:

Always think: “I will not be the first one to have this error, and will not be the last one”

therefore google the error:

> Blockquote
PGSQL.5432" failed: No such file or directory Is the server running locally and accepting connections on that socket

Read around, maybe you will find something that makes you fix your own problem.
Have some links ready for the monday meeting

25

A couple of comments:

You may disable also the build for macos action it takes a lot of time to execute.
We can enable that later.

The check-files action is the easiest to keep passing:

For the signature check:

tools/release-scripts/get_signatures.sh

For the NEWS check: (use only when release_notes.rst changes)

tools/release-scripts/notes2news.pl

for style-check:

tools/scripts/code_checker.sh

That will find style errors like this one:

Modify the code until no errors

1 Like
26

@Saloni-2005 @wifi @bipashabg
Left you some comments on your PR
I hope you can fix those.

And please disable action for centos on your fork

2 Likes
27

Hi @cvvergara, @sanak, and @robe ,

I hope you’re all doing well. Our meeting was originally scheduled for 11:00 AM Shanghai time on July 14, which corresponds to:

  • 10:00 PM Mexico City time on July 13 (@cvvergara)
  • 12:00 PM Osaka time on July 14 (@sanak)
  • (@robe – I’m not sure of your time zone, so please kindly let me know if the following times work for you.)

Unfortunately, I have an very important research funding defense at my university at that exact time tomorrow.

Would it be possible to delay our meeting by one hour ?

The adjusted time would be:

  • 12:00 PM Shanghai time on July 14
  • 11:00 PM Mexico City time on July 13
  • 1:00 PM Osaka time on July 14

If this adjustment is inconvenient for anyone, I’m also happy to postpone the meeting to July 15 instead.

Of course, I will still begin my Week 7 as planned before the meeting.

Thank you all for your understanding!

Best regards,
wifi

28

My time is Boston, USA which looks to be midnight July 14th.

That time works okay for me, though I actually had 10 PM before, so two hours later. Maybe I missed an earlier calendar change.

29

Hi @wifi, @cvvergara, and @robe,

Thanks for bringing that up!
Both delaying by one hour today and postponing to tomorrow work fine for me.
However, today I need to leave in one hour for another meeting.
(Regarding tomorrow’s PSC meeting, we can adjust the start time if needed, I think.)

Best regards,

30

@wifi @cvvergara @sanak so we are meeting in about an hour?

31

Sorry meant 2 hrs from now.

32

ah, yes, 2 hours from now

33

Okay, thanks for confirmation!

34

Hi, @cvvergara @robe @sanak .
I finish my research funding defense now. If time is okay, we can have meeting now.