We are waiting for you
@wifi @bipashabg @Saloni-2005
1 Like
Hi, @cvvergara
I’m really sorry, but I have an really important meeting tonight and might not be able to join. Apologies for the inconvenience, and thank you so much for your understanding.
1 Like
@bipashabg we are starting the week3 meeting
Hello, @cvvergara
I have resolved that conflict you can just check once.
Hello @cvvergara , @robe
I don’t know why again it is showing merge conflicts even though I have disabled the update locale day before yesterday only.
Could you please guide me on this and can you help me the reason behind this so that this should not happen next time ?
Here you can see I have disabled the update locale :
Best Regards,
Saloni Kumari
Is this because I have compiled the code ?
Hi, @cvvergara @robe @sanak @iosefa,
I wanted to check if it’s okay for me to merge the Week 3 PR now, or should I wait for your review and approval?
I’m still seeing pgr_binaryBreadthFirstSearch work in your commit. I would like to see your wifi2005 rebased with develop so you don’t have this dangling breathfirst search. Not a huge deal, but if you can fix that first that would be great.
Hi @robe,
I’ve tried to work on this, but I’m a bit confused now. Would it be possible to discuss it in our next meeting? I’m worried that I might accidentally mess up the week3 branch by running incorrect commands.
Sure. It’s not a huge deal - we were going to discuss in next meeting. I should add if you are done coding for the week go ahead and commit your work.
Some general comments
Focus on your code to reach a stable compiling point
@wifi, @bipashabg @Saloni-2005
That is this week’s goal. Remember.
the rabbit
We will talk about forbidding the use of the coderabbitai in the next Monday meeting, basically:
The rabbit summary and review, when the code is not working is kind of annoying.
(hid the rabbit comment on @wifi PR)
No merge with pgrouting/develop branch
Starting next week you will work without thinking on pgRouting main repository, aka please do not merge with the recent changes of pgrouting/develop branch
With that we will avoid things in your PR commits like:
or like:
and avoid conflicts.
- spent around an hour with @Saloni-2005 to resolve the PR conflicts, succeeded on try-3
- @wifi your PR does not have conflicts, so like @robe mentioned, its not a great deal.
Editor Config
Regardless of the operating system you are using there is a file named
.editorconfig
Many projects have it:
That file is fine tunning the editor to the standard of the projects’s file edition.
So if I work on pgRouting code my editor is set to use the .editoconfig file that it finds on the root of the pgRouting repo.
So if I work on PostGIS code my editor is set to use the .editoconfig file that it finds on the root of the PostGIS repo.
and so on.
That happens because I have set my editor to follow that .editorconfig file.
Please, what ever editor you are using set it up to follow that file.
If you don’t find your file editor in the link then change file editor or google more about it on your file editor website.
Avoid windows EOL (end of line) style
In particular for pgRouting in particular, this line will avoid to have windows EOL style.
@Saloni-2005 will have to change the EOL: ^M (aka the windows EOL style)
Afraid of messing up
That is why you are not working on the main pgRouting repository.
If you mess up:
First define mess up.
Based on the definition then we think about fixing the mess.
GSoC-pgRouting repository was created thinking on the GSoC participants.
You are learning, and if you don’t mess up some times then you are not learning from your mistakes.
Messing up your own branch (aka in your fork or clone) is the least of our concerns.
Messing up pgRouting main repository is a very big concern but you are not working there (yet).
Before saying see you next meeting:
I reiterate on this:
Focus on your code to reach a stable compiling point
@wifi, @bipashabg @Saloni-2005
That is this week’s goal. Remember.