Hi Aurélie
I had a fast glance to the code.
So before thinking on the final PR to pgRouting let me mention that:
- A PR of new functionality has like 5/6 commits, organized per directory: doc, sql, pgtap, docqueries, include, src, tools. That is we don’t want to keep the whole history of the development of the code of the new functionality. (see this PR example
- Maybe like the GSoC students, sometimes the whole work history needs to be kept, that you are doing on your fork.
Now about the code, Normally its new code, as you can see on the above example. But your code is also modifying existing code. Which makes things a little bit more tricky.
When I have encountered that situation, the most recent on vrpRouting, I have to do it in a series of PR, Basically from the PR #43 up to #64 is the work done in “one” branch of my fork. Other wise the review of the code is mostly impossible.
So, in order to prepare your code for merging to pgRouting repository, we can set a weekly meeting where we go thru your code and the steps that need to be done to make it work.
If it can be finish before the v4.0.0 release (on develop) that I am working on, would be lovely, other wise it would be on v4.1.0. So the sooner we get into working on it the better.
For the meeting time and place:
Mondays at 9am on https://meet.osgeo.org/pgrouting
We can have an introductory meeting on the 16th (please confirm). and then continue on January (On Dec 23 I am cooking for the Xmas and on the 30th I am on vacation)
Regards
Vicky