Hi @AuBousquet
Thanks for the PR towards develop branch (aka v4.0.0).
We want to include your work in version 3.8.0 (aka master)
We are on a fast pace working on 4.0.0 and now the PR has conflicts.
The way I will work (like I did with your other PR):
- cherry-pick from the branch from your repository and fix conflicts with version 3.8.0 (aka main)
- Fix issues
- Make PR to main branch
- Merge
- cherry-pick from main branch and fix conflicts with version 4.0.0 (aka develop)
- Make PR to develop branch
- Merge
- Close your PR in favor of the PR done to develop
Things I will be fixing:
pgr_contractionHierarchies fixes
sql:
- Order of optional parameters: “directed” is first
- forbidden_vertices → forbidden
General fixes:
- Fixing licenses
- Removed trailing spaces on files
- Adjust to parameters names and order
pgtap:
- The function is new on 3.8.0
- Adjusting plans and skip message
build:
- Adding pgr_contractionHierarchies signatures in 3.8
doc queries:
- Capitalizing postgreSQL key words
Doc:
- Added Experimental keyword
Fixing C/C++ warnings:
- template-id not allowed for constructor in C++20 [-Wtemplate-id-cdtor]
- no member named remove_edge in namespace boost [clang-diagnostic-error]
- no member named make_iterator_range in namespace boost [clang-diagnostic-error]
Regards