[pgrouting-dev] git dependency in (at least) pgRouting 2.0

Here’s a dependency not listed-- git itself is a dependency… . I know this is a silly thing to point out, but it is possible on github to download a zip of the file without installing git. Should git be added as a dependency?

Best,
Steve

On Sat, May 11, 2013 at 12:59 AM, Stephen Mather
<mather.stephen@gmail.com>wrote:

Here's a dependency not listed-- git itself is a dependency... . I know
this is a silly thing to point out, but it is possible on github to
download a zip of the file without installing git. Should git be added as
a dependency?

I added a Cmake module to get some Git parameters, if available.
It should check if it's not a Git repository, though I didn't think about
it could fail if Git is not installed at all.
Thanks for the comment, because I didn't think about it at all.

I thought the Git module would be smart enough, but of course this
shouldn't become a build dependency.
Will take a look.

Daniel

Best,
Steve

_______________________________________________
pgrouting-dev mailing list
pgrouting-dev@lists.osgeo.org
http://lists.osgeo.org/mailman/listinfo/pgrouting-dev

--
Georepublic UG & Georepublic Japan
eMail: daniel.kastl@georepublic.de
Web: http://georepublic.de

Cool. Thanks Daniel. I figure I’m the first person to try to install it without git… :). It was a fresh install though.

Best,
Steve

···

On Fri, May 10, 2013 at 9:47 PM, Daniel Kastl <daniel@georepublic.de> wrote:


pgrouting-dev mailing list
pgrouting-dev@lists.osgeo.org
http://lists.osgeo.org/mailman/listinfo/pgrouting-dev

On Sat, May 11, 2013 at 12:59 AM, Stephen Mather <mather.stephen@gmail.com> wrote:

Here’s a dependency not listed-- git itself is a dependency… . I know this is a silly thing to point out, but it is possible on github to download a zip of the file without installing git. Should git be added as a dependency?

I added a Cmake module to get some Git parameters, if available.
It should check if it’s not a Git repository, though I didn’t think about it could fail if Git is not installed at all.
Thanks for the comment, because I didn’t think about it at all.

I thought the Git module would be smart enough, but of course this shouldn’t become a build dependency.

Will take a look.

Daniel

Best,
Steve


pgrouting-dev mailing list
pgrouting-dev@lists.osgeo.org
http://lists.osgeo.org/mailman/listinfo/pgrouting-dev


Georepublic UG & Georepublic Japan
eMail: daniel.kastl@georepublic.de
Web: http://georepublic.de

On Sat, May 11, 2013 at 11:22 AM, Stephen Mather
<mather.stephen@gmail.com>wrote:

Cool. Thanks Daniel. I figure I'm the first person to try to install it
without git... :). It was a fresh install though.

Best,
Steve

Hi Steve,

When you meant "Git is a dependency", did you refer to the cmake output
like this?

-- The C compiler identification is GNU 4.7.2
-- The CXX compiler identification is GNU 4.7.2
...
-- Could NOT find Git (missing: GIT_EXECUTABLE)
...

This indicates, that Git isn't installed, but it doesn't prevent you from
compiling.
So it's not really a dependency, but if Git is there and the source is a
Git repository, then (as for now) it will place the version hash in the
documentation for example (in case you build the documentation)

Or do you get errors when trying to compile?

Daniel

On Fri, May 10, 2013 at 9:47 PM, Daniel Kastl <daniel@georepublic.de>wrote:

On Sat, May 11, 2013 at 12:59 AM, Stephen Mather <
mather.stephen@gmail.com> wrote:

Here's a dependency not listed-- git itself is a dependency... . I know
this is a silly thing to point out, but it is possible on github to
download a zip of the file without installing git. Should git be added as
a dependency?

I added a Cmake module to get some Git parameters, if available.
It should check if it's not a Git repository, though I didn't think about
it could fail if Git is not installed at all.
Thanks for the comment, because I didn't think about it at all.

I thought the Git module would be smart enough, but of course this
shouldn't become a build dependency.
Will take a look.

Daniel

Best,
Steve

_______________________________________________
pgrouting-dev mailing list
pgrouting-dev@lists.osgeo.org
http://lists.osgeo.org/mailman/listinfo/pgrouting-dev

--
Georepublic UG & Georepublic Japan
eMail: daniel.kastl@georepublic.de
Web: http://georepublic.de

_______________________________________________
pgrouting-dev mailing list
pgrouting-dev@lists.osgeo.org
http://lists.osgeo.org/mailman/listinfo/pgrouting-dev

_______________________________________________
pgrouting-dev mailing list
pgrouting-dev@lists.osgeo.org
http://lists.osgeo.org/mailman/listinfo/pgrouting-dev

--
Georepublic UG & Georepublic Japan
eMail: daniel.kastl@georepublic.de
Web: http://georepublic.de

I definitely got errors, but I’m wondering if I got the warning, and the errors right after for other unrelated reasons. I’ll see if I can roll back to a state where I can replicate, but it will be Tuesday or Wednesday of next week before I can do that.

Best,
Steve

···

On Fri, May 10, 2013 at 10:35 PM, Daniel Kastl <daniel@georepublic.de> wrote:


pgrouting-dev mailing list
pgrouting-dev@lists.osgeo.org
http://lists.osgeo.org/mailman/listinfo/pgrouting-dev

On Sat, May 11, 2013 at 11:22 AM, Stephen Mather <mather.stephen@gmail.com> wrote:

Cool. Thanks Daniel. I figure I’m the first person to try to install it without git… :). It was a fresh install though.

Best,
Steve

Hi Steve,

When you meant “Git is a dependency”, did you refer to the cmake output like this?

– The C compiler identification is GNU 4.7.2
– The CXX compiler identification is GNU 4.7.2

– Could NOT find Git (missing: GIT_EXECUTABLE)

This indicates, that Git isn’t installed, but it doesn’t prevent you from compiling.
So it’s not really a dependency, but if Git is there and the source is a Git repository, then (as for now) it will place the version hash in the documentation for example (in case you build the documentation)

Or do you get errors when trying to compile?

Daniel


pgrouting-dev mailing list
pgrouting-dev@lists.osgeo.org
http://lists.osgeo.org/mailman/listinfo/pgrouting-dev


Georepublic UG & Georepublic Japan
eMail: daniel.kastl@georepublic.de
Web: http://georepublic.de

On Fri, May 10, 2013 at 9:47 PM, Daniel Kastl <daniel@georepublic.de> wrote:


pgrouting-dev mailing list
pgrouting-dev@lists.osgeo.org
http://lists.osgeo.org/mailman/listinfo/pgrouting-dev

On Sat, May 11, 2013 at 12:59 AM, Stephen Mather <mather.stephen@gmail.com> wrote:

Here’s a dependency not listed-- git itself is a dependency… . I know this is a silly thing to point out, but it is possible on github to download a zip of the file without installing git. Should git be added as a dependency?

I added a Cmake module to get some Git parameters, if available.
It should check if it’s not a Git repository, though I didn’t think about it could fail if Git is not installed at all.
Thanks for the comment, because I didn’t think about it at all.

I thought the Git module would be smart enough, but of course this shouldn’t become a build dependency.

Will take a look.

Daniel

Best,
Steve


pgrouting-dev mailing list
pgrouting-dev@lists.osgeo.org
http://lists.osgeo.org/mailman/listinfo/pgrouting-dev


Georepublic UG & Georepublic Japan
eMail: daniel.kastl@georepublic.de
Web: http://georepublic.de

On Sat, May 11, 2013 at 11:38 AM, Stephen Mather
<mather.stephen@gmail.com>wrote:

I definitely got errors, but I'm wondering if I got the warning, and the
errors right after for other unrelated reasons. I'll see if I can roll
back to a state where I can replicate, but it will be Tuesday or Wednesday
of next week before I can do that.

If you have a chance to post the errors, that would be nice.
I just uninstalled Git for testing, because I have no other environment
here without Git installed :wink:

Then I downloaded
https://github.com/pgRouting/pgrouting/archive/sew-devel-2_0.zip
And to compile I run:

cd pgrouting-sew-devel-2_0/
cmake -H. -Bbuild -DWITH_DD=ON
cd build && make && cd ..

... without errors.
Maybe something else is missing.

But again thanks for pointing out that you can also download the source
from Github as ZIP file. :wink:

Daniel

Best,
Steve

On Fri, May 10, 2013 at 10:35 PM, Daniel Kastl <daniel@georepublic.de>wrote:

On Sat, May 11, 2013 at 11:22 AM, Stephen Mather <
mather.stephen@gmail.com> wrote:

Cool. Thanks Daniel. I figure I'm the first person to try to install
it without git... :). It was a fresh install though.

Best,
Steve

Hi Steve,

When you meant "Git is a dependency", did you refer to the cmake output
like this?

-- The C compiler identification is GNU 4.7.2
-- The CXX compiler identification is GNU 4.7.2
...
-- Could NOT find Git (missing: GIT_EXECUTABLE)
...

This indicates, that Git isn't installed, but it doesn't prevent you from
compiling.
So it's not really a dependency, but if Git is there and the source is a
Git repository, then (as for now) it will place the version hash in the
documentation for example (in case you build the documentation)

Or do you get errors when trying to compile?

Daniel

On Fri, May 10, 2013 at 9:47 PM, Daniel Kastl <daniel@georepublic.de>wrote:

On Sat, May 11, 2013 at 12:59 AM, Stephen Mather <
mather.stephen@gmail.com> wrote:

Here's a dependency not listed-- git itself is a dependency... . I
know this is a silly thing to point out, but it is possible on github to
download a zip of the file without installing git. Should git be added as
a dependency?

I added a Cmake module to get some Git parameters, if available.
It should check if it's not a Git repository, though I didn't think
about it could fail if Git is not installed at all.
Thanks for the comment, because I didn't think about it at all.

I thought the Git module would be smart enough, but of course this
shouldn't become a build dependency.
Will take a look.

Daniel

Best,
Steve

_______________________________________________
pgrouting-dev mailing list
pgrouting-dev@lists.osgeo.org
http://lists.osgeo.org/mailman/listinfo/pgrouting-dev

--
Georepublic UG & Georepublic Japan
eMail: daniel.kastl@georepublic.de
Web: http://georepublic.de

_______________________________________________
pgrouting-dev mailing list
pgrouting-dev@lists.osgeo.org
http://lists.osgeo.org/mailman/listinfo/pgrouting-dev

_______________________________________________
pgrouting-dev mailing list
pgrouting-dev@lists.osgeo.org
http://lists.osgeo.org/mailman/listinfo/pgrouting-dev

--
Georepublic UG & Georepublic Japan
eMail: daniel.kastl@georepublic.de
Web: http://georepublic.de

_______________________________________________
pgrouting-dev mailing list
pgrouting-dev@lists.osgeo.org
http://lists.osgeo.org/mailman/listinfo/pgrouting-dev

_______________________________________________
pgrouting-dev mailing list
pgrouting-dev@lists.osgeo.org
http://lists.osgeo.org/mailman/listinfo/pgrouting-dev

--
Georepublic UG & Georepublic Japan
eMail: daniel.kastl@georepublic.de
Web: http://georepublic.de

On 5/10/2013 10:35 PM, Daniel Kastl wrote:

On Sat, May 11, 2013 at 11:22 AM, Stephen Mather
<mather.stephen@gmail.com <mailto:mather.stephen@gmail.com>> wrote:

    Cool. Thanks Daniel. I figure I'm the first person to try to
    install it without git... :). It was a fresh install though.

    Best,
    Steve

Hi Steve,

When you meant "Git is a dependency", did you refer to the cmake output
like this?

-- The C compiler identification is GNU 4.7.2
-- The CXX compiler identification is GNU 4.7.2
...
-- Could NOT find Git (missing: GIT_EXECUTABLE)

We should make this message clearer something like:

-- Could NOT find GIT -- ok to continue without it.

-Steve W

...

This indicates, that Git isn't installed, but it doesn't prevent you
from compiling.
So it's not really a dependency, but if Git is there and the source is a
Git repository, then (as for now) it will place the version hash in the
documentation for example (in case you build the documentation)

Or do you get errors when trying to compile?

Daniel

    On Fri, May 10, 2013 at 9:47 PM, Daniel Kastl <daniel@georepublic.de
    <mailto:daniel@georepublic.de>> wrote:

        On Sat, May 11, 2013 at 12:59 AM, Stephen Mather
        <mather.stephen@gmail.com <mailto:mather.stephen@gmail.com>> wrote:

            Here's a dependency not listed-- git itself is a
            dependency... . I know this is a silly thing to point out,
            but it is possible on github to download a zip of the file
            without installing git. Should git be added as a dependency?

        I added a Cmake module to get some Git parameters, if available.
        It should check if it's not a Git repository, though I didn't
        think about it could fail if Git is not installed at all.
        Thanks for the comment, because I didn't think about it at all.

        I thought the Git module would be smart enough, but of course
        this shouldn't become a build dependency.
        Will take a look.

        Daniel

            Best,
            Steve

            _______________________________________________
            pgrouting-dev mailing list
            pgrouting-dev@lists.osgeo.org
            <mailto:pgrouting-dev@lists.osgeo.org>
            http://lists.osgeo.org/mailman/listinfo/pgrouting-dev

        --
        Georepublic UG & Georepublic Japan
        eMail: daniel.kastl@georepublic.de
        <mailto:daniel.kastl@georepublic.de>
        Web: http://georepublic.de/&gt;

        _______________________________________________
        pgrouting-dev mailing list
        pgrouting-dev@lists.osgeo.org <mailto:pgrouting-dev@lists.osgeo.org>
        http://lists.osgeo.org/mailman/listinfo/pgrouting-dev

    _______________________________________________
    pgrouting-dev mailing list
    pgrouting-dev@lists.osgeo.org <mailto:pgrouting-dev@lists.osgeo.org>
    http://lists.osgeo.org/mailman/listinfo/pgrouting-dev

--
Georepublic UG & Georepublic Japan
eMail: daniel.kastl@georepublic.de <mailto:daniel.kastl@georepublic.de>
Web: http://georepublic.de/&gt;

_______________________________________________
pgrouting-dev mailing list
pgrouting-dev@lists.osgeo.org
http://lists.osgeo.org/mailman/listinfo/pgrouting-dev

-- The C compiler identification is GNU 4.7.2
-- The CXX compiler identification is GNU 4.7.2
...
-- Could NOT find Git (missing: GIT_EXECUTABLE)

We should make this message clearer something like:

-- Could NOT find GIT -- ok to continue without it.

Do you know how to change this?
I think it's something from Cmake's "find_package" and I can't see where to
change the output message:
http://cmake.org/cmake/help/v2.8.8/cmake.html#command:find_package

Daniel

--
Georepublic UG & Georepublic Japan
eMail: daniel.kastl@georepublic.de
Web: http://georepublic.de

On Sat, May 11, 2013 at 1:26 PM, Daniel Kastl <daniel@georepublic.de> wrote:

-- The C compiler identification is GNU 4.7.2
-- The CXX compiler identification is GNU 4.7.2
...
-- Could NOT find Git (missing: GIT_EXECUTABLE)

We should make this message clearer something like:

-- Could NOT find GIT -- ok to continue without it.

Do you know how to change this?
I think it's something from Cmake's "find_package" and I can't see where
to change the output message:
http://cmake.org/cmake/help/v2.8.8/cmake.html#command:find_package

Set the "find_package" status message to "QUIET" and added custom status
messages afterwards.

Daniel

--
Georepublic UG & Georepublic Japan
eMail: daniel.kastl@georepublic.de
Web: http://georepublic.de