[pgrouting-dev] Renaming TYPE structures?

pgRouting pgrouting-dev
1

Hi Daniel, et al,

I have added renaming the pgrouting types to the spreadsheet. But I'm concerned about doing this for a few reasons. If we are going to change the types, this needs to be done first to avoid having to touch all the SQL code twice.

pros:

1. it gives a more consistent naming through the project

cons:

1. this change is more invasive because it propagates into the C code

2. it may break the ability of legacy functions from working with old existing code unless it is possible to define a CAST that would map the new type to the old type like:

create cast (pgr_pathResult as path_result)
    without function as implicit;

I have not tried this but it seems like it might work.

Thoughts?

-Steve

2

Hello,

I think it makes sense to the naming consistent for this release since it will only get harder to change in the future.

On a hopefully related note, is there a reason that path_result does not include an explicit edge order? I'm using row_number() OVER (PARTITION BY routeid) to generate one, but my understanding is that this isn't guaranteed to preserve the correct ordering? I also assume that it's adding considerable overhead to the query.

Best,
Alec

On May 10, 2013, at 11:36 AM, Stephen Woodbridge <woodbri@swoodbridge.com> wrote:

Hi Daniel, et al,

I have added renaming the pgrouting types to the spreadsheet. But I'm concerned about doing this for a few reasons. If we are going to change the types, this needs to be done first to avoid having to touch all the SQL code twice.

pros:

1. it gives a more consistent naming through the project

cons:

1. this change is more invasive because it propagates into the C code

2. it may break the ability of legacy functions from working with old existing code unless it is possible to define a CAST that would map the new type to the old type like:

create cast (pgr_pathResult as path_result)
  without function as implicit;

I have not tried this but it seems like it might work.

Thoughts?

-Steve
_______________________________________________
pgrouting-dev mailing list
pgrouting-dev@lists.osgeo.org
http://lists.osgeo.org/mailman/listinfo/pgrouting-dev