Ready to ImageN more? (merging upgrade PRs)

GeoServer GeoServer Developer
,
1

Hi all,
jokes aside, the PRs for ImageN integration are ready:

They switch the geo-trio to ImageN 0.4 snapshot and ImageIO-Ext 2.0 snapshot,
handling all the necessary code changes.

They are snapshots because this is just the beginning, the javadoc and
documentation still have plenty of references to JAI, and even ImageN itself
still has classes named “JAI-something”.

While not 100% complete, I’d rather merge them now, on the development branch,
as they would quickly bit-rot otherwise.
The Java17 OpenRewrite PRs will likely suffer some, but hopefully they can be recovered
by re-applying OpenRewrite again, and the commits to fix some of the build/compile failure after that.

The work remaining once the ImageN branches land is cleanup of docs and lots of testing (let’s have a milestone build for everyone to play with maybe?) in preparation for 2.28.0.

It goes without saying, I’ll expect some rocky road ahead of us in the few days after the merge (and mind, next week I’m not around).

Anyhow. Want to merge now? If not, can anyone take care of it after the necessary discussion and amendments, next week?

2

First of all congratulations, I am personally very happy to see this finally happen! And then yes let’s merge now at this work is too important to bit rot and rebase and so on.

I am going to go review the PRs now while I wait for this discussion to settle.

Jody

3

Sounds like a good plan to me

Ian

4

Hi all,
while Andrea is not around this week, I have locally built everything in the line:

  • imageio-ext (2.0 snapshot)
  • imagen (0.4 snapshot)
  • geotools (branch imagen)
  • gwc (branch imagen)
  • geoserver (branch imagen)
    and locally deployed on Tomcat.

I did a quick test on a sample raster layer and it rendered so I will start merging the PRs to avoid accumulating future conflict

5

Sounds good, I was unable to render yesterday but will try again now.

I have been accumulating non-functional feedback as small PRs:

If it worksI agree we should go ahead.

I would like to tag an ImageN 0.4 when we have completed the addition of JAI-Ext, even just for the historical record. If people feel strongly that it should be a 1.0 release then I will need to do some work on the docs, renaming JAI to ImageN etc…

6

I have been able to test today, able to render raster data :slight_smile:

@danieleromagnoli I will check for you today to coordinate,

  • imagen
  • imageio-ext main branch is already using imagen.version 0.4-SNAPSHOT

I have disabled the build.geoserver.org main jobs, and am starting to merge in order and turn on jobs one by one.

7

Merging and enabling jobs one by one are we down to:

The following CITE tests are failing:

  • Run CITE Tests / CITE (geotiff11)
  • Run CITE Tests / CITE (wcs11)

So far it looks like they are just not starting up:

Waiting for http://localhost:18090/geoserver/web/wicket/resource/org.geoserver.web.GeoServerBasePage/img/logo.png...
Timeout reached: http://localhost:18090/geoserver/web/wicket/resource/org.geoserver.web.GeoServerBasePage/img/logo.png is not available after 60 seconds
8

Main builds are back, nightly builds available!