[SAC] [OSGeo] #2980: Change default committer name and email on weblate

#2980: Change default committer name and email on weblate
---------------------------+--------------------------------------
Reporter: robe | Owner: sac@…
     Type: task | Status: new
Priority: normal | Milestone: Sysadmin Contract 2023-I
Component: Systems Admin | Keywords:
---------------------------+--------------------------------------
Right now whenever a commit is done on weblate it shows committed by
weblate and links users to the weblate account (if on github).

This should be changed to osgeoweblate osgeoweblate (OSGeo Weblate) · GitHub and
the email address I had setup for it so it properly links to the
osgeoweblate account on github.

Looks like the way to fix this is to setup:

DEFAULT_COMMITER_EMAIL and DEFAULT_COMMITER_NAME
as mentioned here:

docs: Fix description of git committer · WeblateOrg/weblate@3c784ca · GitHub

I'm going to do that shortly and then monitor for commits to confirm it
does change
--
Ticket URL: <https://trac.osgeo.org/osgeo/ticket/2980&gt;
OSGeo <Gter - OSGeo;
OSGeo committee and general foundation issue tracker.

#2980: Change default committer name and email on weblate
---------------------------+---------------------------------------
Reporter: robe | Owner: sac@…
     Type: task | Status: new
Priority: normal | Milestone: Sysadmin Contract 2023-I
Component: Systems Admin | Resolution:
Keywords: |
---------------------------+---------------------------------------
Comment (by neteler):

Would you mind to explain how the mechanism works?

I see a badly outdated fork here, e.g.:
https://github.com/osgeoweblate/grass

What would be the advantage to point to the osgeoweblate forks?
--
Ticket URL: <https://trac.osgeo.org/osgeo/ticket/2980#comment:1&gt;
OSGeo <https://osgeo.org/&gt;
OSGeo committee and general foundation issue tracker.

#2980: Change default committer name and email on weblate
---------------------------+---------------------------------------
Reporter: robe | Owner: sac@…
     Type: task | Status: new
Priority: normal | Milestone: Sysadmin Contract 2023-I
Component: Systems Admin | Resolution:
Keywords: |
---------------------------+---------------------------------------
Comment (by robe):

Neteler,

Hmm I guess this isn't detailed here -
https://wiki.osgeo.org/wiki/SAC:Weblate
I apologize. I'll try to flesh that out a bit.

What I am talking about here, is how the commits credits shows on github.
It doesn't change the process.
Below the commits would show "weblate" even though it was "osgeoweblate"
because it has noreply@weblate.com as the email address. and if people
would click on the link, it would take them to github/osgeoweblate
instead of github.com/osgeoweblate as you can see in workshop contributors
- https://github.com/postgis/postgis-workshops/graphs/contributors and the
combined would do the same - https://github.com/postgis/postgis-
workshops/commit/25f3aab715ff75aba7b4d353de418205f9ad837f (authored by
real author, committed by weblate).

So this change is mostly cosmetic and to get rid of confusion, and doesn't
affect the flow (or at least shouldn't).

Now to you question about staleness

It looks like grass is setup right - using Github Pull Request mode, but I
am seeing this notice

"The repository is outdated. You might not get expected results until you
update it."

So yours seems to be a separate issue which I'll ticket as a separate

But so I remember to update wiki

So here is the process.

There are two approaches you can go with whichever makes you feel most
comfortable

1. You can specify in weblate, you want just git. If you go with that you
have to
a) Give osgeoweblate commit access to your repo
(with option of allowing commit or waiting for someone to manually push) -
this is the option that postgis core project uses
https://git.osgeo.org/gitea/postgis/postgis/commit/b74322912e5321e6df5bcbe0457cb40e8117bbdd
(we don't bother with pull requests, just let it flow thru and if it
breaks something we handle it after it has been dropped)
or

b) Manually download and push the commits yourself

Option 2

2. You specify Github Pull mode (on your base component, the component
that all your other components were copied from):
(this is what https://github.com/postgis/postgis-workshops uses and
pgrouting and osgeolive I think)
https://weblate.osgeo.org/settings/grass-gis/grasslibs/#vcs and grass is
doing
(I think you should be able to see that page with your ldap account), note
there we have:

Version control system: Github pull request

When you choose Github pull request, it uses the github account
osgeoweblate, I had set up for this purpose. This account acts like a
person, pulling in weblates changes and then creating a pull request
against your repo.

I should add regardless the option you choose, there is a "Component
discovery" plugin you should install on the first component you set up.
This allows weblate to auto-generate new components based on the pattern
of your first component and I think it has a checkbox to also remove no
longer present components.

That last bit might be what grass is missing. Anyway let me put in a
separate ticket for grass issue.

PostGIS workshop which uses the pull request model:

Here is how it works
--
Ticket URL: <https://trac.osgeo.org/osgeo/ticket/2980#comment:2&gt;
OSGeo <https://osgeo.org/&gt;
OSGeo committee and general foundation issue tracker.

#2980: Change default committer name and email on weblate
---------------------------+---------------------------------------
Reporter: robe | Owner: sac@…
     Type: task | Status: closed
Priority: normal | Milestone: Sysadmin Contract 2023-I
Component: Systems Admin | Resolution: fixed
Keywords: |
---------------------------+---------------------------------------
Changes (by robe):

* status: new => closed
* resolution: => fixed

Comment:

I'm going to close this one out since it's done. I'll reopen if it still
looks to be an issue.
--
Ticket URL: <https://trac.osgeo.org/osgeo/ticket/2980#comment:3&gt;
OSGeo <https://osgeo.org/&gt;
OSGeo committee and general foundation issue tracker.

#2980: Change default committer name and email on weblate
---------------------------+---------------------------------------
Reporter: robe | Owner: sac@…
     Type: task | Status: reopened
Priority: normal | Milestone: Sysadmin Contract 2023-I
Component: Systems Admin | Resolution:
Keywords: |
---------------------------+---------------------------------------
Changes (by robe):

* status: closed => reopened
* resolution: fixed =>

Comment:

I don't think this is working.

I just merged a pull request and is still showing weblate as the secondary
author and pointing at the github.com/weblate org which implodes since so
many projects are using hosted-weblate/github

https://github.com/postgis/postgis-
workshops/commit/14e631655cda27d38b304f629827814842aaa260
--
Ticket URL: <https://trac.osgeo.org/osgeo/ticket/2980#comment:4&gt;
OSGeo <https://osgeo.org/&gt;
OSGeo committee and general foundation issue tracker.

#2980: Change default committer name and email on weblate
---------------------------+---------------------------------------
Reporter: robe | Owner: sac@…
     Type: task | Status: reopened
Priority: normal | Milestone: Sysadmin Contract 2023-I
Component: Systems Admin | Resolution:
Keywords: |
---------------------------+---------------------------------------
Comment (by cvvergara):

I dont see it pointing to github.com/weblate org
--
Ticket URL: <https://trac.osgeo.org/osgeo/ticket/2980#comment:5&gt;
OSGeo <https://osgeo.org/&gt;
OSGeo committee and general foundation issue tracker.

#2980: Change default committer name and email on weblate
---------------------------+---------------------------------------
Reporter: robe | Owner: sac@…
     Type: task | Status: reopened
Priority: normal | Milestone: Sysadmin Contract 2023-I
Component: Systems Admin | Resolution:
Keywords: |
---------------------------+---------------------------------------
Changes (by robe):

* Attachment "weblate-author.png" added.

weblate-author
--
Ticket URL: <https://trac.osgeo.org/osgeo/ticket/2980&gt;
OSGeo <https://osgeo.org/&gt;
OSGeo committee and general foundation issue tracker.

#2980: Change default committer name and email on weblate
---------------------------+---------------------------------------
Reporter: robe | Owner: sac@…
     Type: task | Status: reopened
Priority: normal | Milestone: Sysadmin Contract 2023-I
Component: Systems Admin | Resolution:
Keywords: |
---------------------------+---------------------------------------
Comment (by robe):

If you look at the two users on that commit above. One of them is
https://github.com/yellow-affrc (who is the Japanese translator) and the
other is https://github.com/weblate

it's very subtle. You have to mouse over to see it and click on the
hyperlink

[[Image(weblate-author.png)]]
--
Ticket URL: <https://trac.osgeo.org/osgeo/ticket/2980#comment:6&gt;
OSGeo <https://osgeo.org/&gt;
OSGeo committee and general foundation issue tracker.

#2980: Change default committer name and email on weblate
---------------------------+---------------------------------------
Reporter: robe | Owner: sac@…
     Type: task | Status: reopened
Priority: normal | Milestone: Sysadmin Contract 2023-I
Component: Systems Admin | Resolution:
Keywords: |
---------------------------+---------------------------------------
Comment (by neteler):

Robe,

Replying to [comment:2 robe]:
> Neteler,
>
> Hmm I guess this isn't detailed here -
https://wiki.osgeo.org/wiki/SAC:Weblate
> I apologize. I'll try to flesh that out a bit.

Do you see a chance to detail it a bit more? It is unclear what the roles
are and how troubleshooting works. Also, that a mirror GitHub repo exists
etc.
Sorry for bothering, but some explanations on the Wiki page may reduce the
actual confusion.
--
Ticket URL: <https://trac.osgeo.org/osgeo/ticket/2980#comment:7&gt;
OSGeo <https://osgeo.org/&gt;
OSGeo committee and general foundation issue tracker.

#2980: Change default committer name and email on weblate
---------------------------+---------------------------------------
Reporter: robe | Owner: sac@…
     Type: task | Status: reopened
Priority: normal | Milestone: Sysadmin Contract 2023-I
Component: Systems Admin | Resolution:
Keywords: |
---------------------------+---------------------------------------
Comment (by robe):

Replying to [comment:7 neteler]:
> Robe,
>
> Replying to [comment:2 robe]:
> > Neteler,
> >
> > Hmm I guess this isn't detailed here -
https://wiki.osgeo.org/wiki/SAC:Weblate
> > I apologize. I'll try to flesh that out a bit.
>
> Do you see a chance to detail it a bit more? It is unclear what the
roles are and how troubleshooting works. Also, that a mirror GitHub repo
exists etc.
> Sorry for bothering, but some explanations on the Wiki page may reduce
the actual confusion.

Apologies. I've added some more explanation. Feel free to add anymore
you feel is unclear.
--
Ticket URL: <https://trac.osgeo.org/osgeo/ticket/2980#comment:8&gt;
OSGeo <https://osgeo.org/&gt;
OSGeo committee and general foundation issue tracker.