Spring 7 update

GeoServer GeoServer Developer
,
1

Hi all,

following up with GSIP-226 (GeoServer 3) we have a set of pull requests migrating the GeoServer ecosystem to Spring 7, in order to get longer term support from that critical library (Spring 6 is going to be EOL middle of the year, if they don’t change their plans).

Coming along with Spring 7 is the upgrade from Jackson 2 to Jackson 3, as Spring 7 deprecated Jackson 2 support.

The pull requests invelved are:

The spring-security upgrade was uneventul, but only because the security subsystem already has a robust set of deprecation suppressions… when switching to Spring 8 some significant parts will have to be rewritten. Regardless, tests are passing in all supported land. The unsupported OIDC module has two failures in the KeycloackIntegrationTest, but I cannot quickly figure out what’s going on, someone with more experience with OIDC would probably better.

To go along with the rest we’re expecting some changes to the printing module, an upgrade to the HTTP client and a Spring 7 update there as well (MapFish Print seems to be using Spring as a dependency injection framework, but I don’t see usage of MVC/Controllers). I’m not sure about what’s going there, out of a whim I changed the Spring version to 7 in the main pom, and it’s still building fine, althought I cannot vouch for actual working. The two extremes are either that it’s really that simple, or that the testing is weak and the actual issues will pop up only with actual usage.

Anyhow, how to proceed from here:

  • If you have any feedback, please let us know ASAP
  • If you can please review the PRs and/or try them out
  • Someone (Alessio, Cecile?) to check the OIDC test failure

Cheers
Andrea

2

For completeness Update to Spring Framework 7.0.2 by jodygarnett · Pull Request #45 · mapfish/mapfish-print-v2 · GitHub

I expect both things are correct: testing is that weak, and the use is very simple.

3

Hello Andrea,
thanks for the effort. I can check the failures on OIDC.

4

Tested with Spring7, the plugin looks good.
Also sent some PRs in order to fix the failing tests.